-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compat types #1752
Merged
Merged
Fix compat types #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does type CreateHandle<T> = () => T;
export function useImperativeHandle<T>(ref: PreactRef<T>, create: CreateHandle<T>, inputs?: Inputs): void; |
JoviDeCroock
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little remark about the typings the rest looks great!
developit
reviewed
Jul 9, 2019
pmkroeker
reviewed
Jul 11, 2019
marvinhagemeister
force-pushed
the
compat_types
branch
from
September 9, 2019 17:33
74d7d67
to
ac958aa
Compare
Co-Authored-By: Leah <leah@hrmny.sh>
marvinhagemeister
force-pushed
the
compat_types
branch
from
September 9, 2019 17:36
9de4e8c
to
43bb2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1751 .
cc to our typings god @pmkroeker