Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat types #1752

Merged
merged 5 commits into from
Sep 9, 2019
Merged

Fix compat types #1752

merged 5 commits into from
Sep 9, 2019

Conversation

marvinhagemeister
Copy link
Member

Fixes #1751 .

cc to our typings god @pmkroeker

@coveralls
Copy link

coveralls commented Jul 4, 2019

Coverage Status

Coverage increased (+0.1%) to 99.882% when pulling 43bb2e6 on compat_types into fed42bb on master.

@weijarz
Copy link

weijarz commented Jul 4, 2019

Does CreateHandle also need to be parameterized?

type CreateHandle<T> = () => T;

export function useImperativeHandle<T>(ref: PreactRef<T>, create: CreateHandle<T>, inputs?: Inputs): void;

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little remark about the typings the rest looks great!

compat/src/index.d.ts Outdated Show resolved Hide resolved
compat/src/suspense.d.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forwardRef in TypeScript
8 participants