-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) - transitions #1804
(fix) - transitions #1804
Conversation
Hey. Thanks for the PR! :) Even throught I mentioned specifically So...maybe we should use a generic code like the one found on #1590 to detect which events to patch for, and maybe verifying if the attribute doesn't exist on DOM element first? I don't know..these are just ideas. But anyway thanks for the PR. I hope I can help on the discussion. =) |
@fjorgemota this PR is intended as a starting point for discussing if we want to support these events. The solution of #1589 can't be used since this breaks testing envs. If we would agree on this I would suggest looking for the postfix start/end and using that to determine a toLowerCase() |
@JoviDeCroock oh. Ok then. Fair enough. I'm waiting for the reviews and further discussion, then. Thanks! :) |
A thought: for DOM nodes ( |
@developit yes, so we want to support these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the golfing! Putting it into applyEventNormalization
is the right way forward. Thank you so much for another awesome PR 🎉
Fixes: #1798
This PR should serve as a deciding point whether or not we want to support these cases to improve React compat.