Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined styles not being cleared #1853

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Fix undefined styles not being cleared #1853

merged 1 commit into from
Aug 11, 2019

Conversation

marvinhagemeister
Copy link
Member

Fixes #1850 .
Adds +2 B 🎉

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.876% when pulling da7e682 on fix_styles_clearing into 42aff16 on master.

JoviDeCroock
JoviDeCroock approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@marvinhagemeister marvinhagemeister merged commit 46f1f02 into master Aug 11, 2019
@marvinhagemeister marvinhagemeister deleted the fix_styles_clearing branch August 11, 2019 13:37
@marvinhagemeister marvinhagemeister mentioned this pull request Aug 11, 2019
Merged
@cloudkite
Copy link

I believe this change breaks setting unitless styles values to 0 for example style={{opacity: 0}} since 0 is falsy therefore will be set to null

@cloudkite cloudkite mentioned this pull request Sep 11, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@developit developit Awaiting requested review from developit

@cristianbote cristianbote Awaiting requested review from cristianbote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Material UI example not working as in react
4 participants
@marvinhagemeister @coveralls @cloudkite @JoviDeCroock