Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) - double replaceNode #1970

Merged
merged 3 commits into from
Oct 3, 2019
Merged

(fix) - double replaceNode #1970

merged 3 commits into from
Oct 3, 2019

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Oct 2, 2019 •
edited
Loading

Fixes slack issue provided by @jviide

@JoviDeCroock
(chore) - undo deletion of space
0418c54
@JoviDeCroock
(chore) - remove spaces
5538941 
NOTE to self: don't use GitHub editor for js changes
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.767% when pulling 5538941 on fix/replace into 9ddc04e on master.

developit
developit approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooh wow that is a good catch.

marvinhagemeister
marvinhagemeister approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@marvinhagemeister marvinhagemeister merged commit b85135d into master Oct 3, 2019
@marvinhagemeister marvinhagemeister deleted the fix/replace branch October 3, 2019 06:00
@marvinhagemeister marvinhagemeister mentioned this pull request Oct 18, 2019
Closed
This was referenced Oct 26, 2019
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit developit approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@cristianbote cristianbote Awaiting requested review from cristianbote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoviDeCroock @coveralls @developit @marvinhagemeister