(fix) - should reorder memoized children #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested review from
developit,
andrewiggins,
marvinhagemeister and
cristianbote
|
Oh that'd be really cool 👍💯 We should double check with the rest cases from #1879 just to be sure that we don't introduce any regressions |
|
@marvinhagemeister can confirm the demo still works |
developit
approved these changes
Oct 6, 2019
cristianbote
reviewed
Oct 7, 2019
| @@ -90,7 +90,7 @@ export function diff(parentDom, newVNode, oldVNode, context, isSvg, excessDomChi | |||
| c.state = c._nextState; | |||
| c._dirty = false; | |||
| c._vnode = newVNode; | |||
| newVNode._dom = oldDom!=null ? oldDom!==oldVNode._dom ? oldDom : oldVNode._dom : null; | |||
| newVNode._dom = oldVNode._dom; | |||
There was a problem hiding this comment.
This line always confused me 😄 anyway. Good catch!
cristianbote
pushed a commit
that referenced
this pull request
Oct 8, 2019
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So apparently the fix introduced in the other PR where we make children point to their parents make this line irrelevant.
Save bytes + fix code 🎉
-15B