-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic formatting via prettier #2065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed package.json
, git hooks LGTM.
Added a nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew! 😅 Went through the files. Things look good! So excited to be able to start using my editor's formatter again (my default VSCode formatter is Prettier).
I have some changes I'll submit in a follow up PR to clean up some gnarly lines I saw. Figured it made since to do in a follow up cuz they somehow save bytes and this PR should be about not changing the size at all, to prove Prettier doesn't do that.
Oh! I also confirmed on my machine that this PR doesn't change gzip size for any of our modules |
Long time coming 🎉