Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic formatting via prettier #2065

Merged
merged 8 commits into from
Oct 30, 2019
Merged

Add automatic formatting via prettier #2065

merged 8 commits into from
Oct 30, 2019

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Oct 29, 2019

Long time coming 🎉

  • Add prettier
  • Format all source code
  • Apply formatting via git hooks automatically
  • Make sure that it has no effect on size 🎉
  • Update eslint config

@coveralls
Copy link

coveralls commented Oct 29, 2019

Coverage Status

Coverage increased (+0.002%) to 99.889% when pulling a1118c8 on prettier-2 into 5eee583 on master.

Copy link
Member

@prateekbh prateekbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed package.json, git hooks LGTM.
Added a nit

package.json Outdated Show resolved Hide resolved
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew! 😅 Went through the files. Things look good! So excited to be able to start using my editor's formatter again (my default VSCode formatter is Prettier).

I have some changes I'll submit in a follow up PR to clean up some gnarly lines I saw. Figured it made since to do in a follow up cuz they somehow save bytes and this PR should be about not changing the size at all, to prove Prettier doesn't do that.

@andrewiggins
Copy link
Member

Oh! I also confirmed on my machine that this PR doesn't change gzip size for any of our modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants