Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting #2066

Merged
merged 8 commits into from
Oct 30, 2019
Merged

Improve formatting #2066

merged 8 commits into from
Oct 30, 2019

Conversation

andrewiggins
Copy link
Member

Summary:

  • Reformat a ternary condition in compat (-2 B)
  • Reformat debug error messages (-15 B)
  • Add some missing brackets around multi-line if/for loops
  • Move preact.min.js copy to build task so we can still pass custom options directly to build:core (e.g. npm run build:core -- --no-compress
  • Other small formatting improvements

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 99.89% when pulling b8e0be9 on feat/improve-formatting into a1118c8 on prettier-2.

marvinhagemeister
marvinhagemeister approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🎉

@marvinhagemeister marvinhagemeister merged commit f844c12 into prettier-2 Oct 30, 2019
@marvinhagemeister marvinhagemeister deleted the feat/improve-formatting branch October 30, 2019 09:32
@andrewiggins andrewiggins restored the feat/improve-formatting branch October 30, 2019 18:19
@andrewiggins andrewiggins deleted the feat/improve-formatting branch October 30, 2019 18:25
@andrewiggins andrewiggins mentioned this pull request Oct 30, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewiggins @coveralls @marvinhagemeister @JoviDeCroock