Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'as' html attribute to TypeScript defs #2068

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Add 'as' html attribute to TypeScript defs #2068

merged 1 commit into from
Oct 30, 2019

Conversation

jakearchibald
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.889% when pulling 2a139ea on jakearchibald:patch-1 into 0b7b2a7 on preactjs:master.

marvinhagemeister
marvinhagemeister approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that there is an as attribute 🎉 Thanks a bunch for your PR 👍

@jakearchibald
Copy link
Contributor Author

Coverage increased (+0.1%)

Go me 🏅

@marvinhagemeister marvinhagemeister merged commit 3a16fc7 into preactjs:master Oct 30, 2019
@jakearchibald jakearchibald deleted the patch-1 branch October 30, 2019 09:22
@jakearchibald
Copy link
Contributor Author

@marvinhagemeister thanks for merging!

@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakearchibald @coveralls @marvinhagemeister