Suspended components should rerender through sCU #2125
Conversation
|
Your current approach is currently running into similar issues as #2159 This makes me rethink our decision to unmount suspended content instead of adding |
andrewiggins
force-pushed
the
fix/suspense-scu
branch
from
db8b819
to
399ca4a
Compare
|
Size Change: +122 B (0%) Total Size: 38.4 kB
ℹ️ View Unchanged
|
andrewiggins
force-pushed
the
fix/suspense-scu
branch
from
399ca4a
to
658b40b
Compare
| c._vnode._children[0] = c.state._suspended; | ||
| c.setState({ _suspended: (c._detachOnNextRender = null) }); | ||
|
|
||
| let suspended; |
There was a problem hiding this comment.
I didn't spend much time golfing this so there might be a smaller alternative
|
|
||
| let suspended; | ||
| while ((suspended = c._suspenders.pop())) { | ||
| suspended.forceUpdate(); |
There was a problem hiding this comment.
Note: I think this is a no-op if no sCU component is between Suspense and Lazy cuz process() will sort the render such that Suspense and all its children are diffed first, then when the Lazy forceUpdate are handled, the component will no longer be marked "_dirty" so they will be skipped
| @@ -55,7 +56,7 @@ export function createSuspender(DefaultComponent) { | |||
| } | |||
|
|
|||
| render(props, state) { | |||
| return state.Lazy ? h(state.Lazy, {}) : h(DefaultComponent, {}); | |||
| return state.Lazy ? h(state.Lazy, props) : h(DefaultComponent, props); | |||
There was a problem hiding this comment.
Are props really meant to be passed down?
There was a problem hiding this comment.
That was my intention. Mimics what React.lazy allows: https://codesandbox.io/s/reactlazy-prop-passing-b8txb
andrewiggins
changed the title
* Add test for suspending component through sCU blocking component * Add test for passing props through Lazy * Add test for using suspense with createContext * Add tests for initially lazy and delayed lazy components with sCU and createContext * Fix typo in unmounted component warning * Add test for multi-suspend under sCU * Improve debug suspense tests * Force update all suspended components when suspension is complete (+31 B)
Resurrecting the awesome work @sventschui did in #1660 now built on top of @jviide and @prateekbh suspense changes. Just calls
forceUpdateon the suspended component to guarantee it rerenders when the promise resolves.Fixes #2176