Rewrite some tests to no longer rely on internals #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewiggins
commented
Nov 15, 2019
| @@ -1809,24 +1795,6 @@ describe('Components', () => { | |||
| expect(child._vnode._dom).to.equalNode(child.base); | |||
| }); | |||
|
|
|||
| it('should update old dom on forceUpdate in a lifecycle', () => { | |||
There was a problem hiding this comment.
I just moved this test into the forceUpdate describe section below.
| } from '../_util/helpers'; | ||
| import { div, span, p } from '../_util/dom'; | ||
|
|
||
| /** @jsx createElement */ | ||
| const h = createElement; | ||
|
|
||
| let spyAll = obj => Object.keys(obj).forEach(key => sinon.spy(obj, key)); |
There was a problem hiding this comment.
Removed this copy of the spyAll function and replaced it with the same function declared in helpers.js. Same for sortAttributes below
marvinhagemeister
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stepping stone to allowing us to run tests against minified builds