Optimize createElement() #2135
Merged
Optimize createElement() #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
requested review from
andrewiggins,
marvinhagemeister and
JoviDeCroock
| props = assign({}, props); | ||
| let normalizedProps = {}, | ||
| i; | ||
| for (i in props) { |
src/create-element.js
Outdated
| // Note: type may be undefined in development, must never error here. | ||
| if (typeof type === 'function' && type.defaultProps != null) { | ||
| for (i in type.defaultProps) { | ||
| if (typeof normalizedProps[i] === 'undefined') |
There was a problem hiding this comment.
can't we just do === undefined or is typeof cheaper?
There was a problem hiding this comment.
I believe in this case we can use === yes, I actually was testing this and forgot to remove it.
JoviDeCroock
approved these changes
Nov 18, 2019
andrewiggins
approved these changes
Nov 18, 2019
test/shared/createElement.test.js
Outdated
| expect(<div />).to.have.property('key').that.is.undefined; | ||
| expect(<div a="a" />).to.have.property('key').that.is.undefined; | ||
| expect(<div />).to.have.property('key').that.is.empty; | ||
| expect(<div a="a" />).to.have.property('key').that.is.empty; |
There was a problem hiding this comment.
I think these assertions want to be .to.not.exist which would pass for null or undefined
There was a problem hiding this comment.
whoops, I literally read that in the docs and then wrote .empty. Tired me is tired!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding shape mutation on props seems to give a 20% improvement in benchmarks.