fix renderer tests by using sinon global #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
reviewed
Dec 30, 2019
marvinhagemeister
approved these changes
Dec 31, 2019
There was a problem hiding this comment.
Good catch about the sinon imports 👍
FYI: With the next version of devtools nearly all of the adapter code can be removed, because it's injected by the extension itself. It's probably a good month until then, but it's coming 🙂 t
Than we can remove the flakey tests altogether 💯
|
@marvinhagemeister do we merge it with less coverage or leave it failing for now? |
|
@JoviDeCroock I'm fine with merging this, because we'll run into the same issue sooner or later when the next version of devtools comes out. Just remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing on master IE11 due to the sinon import