Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid stale closure in error boundary #2225

Merged
merged 1 commit into from
Jan 3, 2020
Merged

avoid stale closure in error boundary #2225

merged 1 commit into from
Jan 3, 2020

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 3, 2020 •
edited
Loading

Thanks @sventschui

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 97.749% when pulling 7f1b5c4 on fix/stale_closure_error_boundary into 9c608c1 on master.

marvinhagemeister
marvinhagemeister approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@JoviDeCroock JoviDeCroock merged commit c323953 into master Jan 3, 2020
@JoviDeCroock JoviDeCroock deleted the fix/stale_closure_error_boundary branch January 3, 2020 13:14
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@robertknight robertknight Awaiting requested review from robertknight

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@cristianbote cristianbote Awaiting requested review from cristianbote

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @marvinhagemeister