Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the package-lock.json #2254

Merged
merged 4 commits into from
Jan 16, 2020
Merged

adding the package-lock.json #2254

merged 4 commits into from
Jan 16, 2020

Conversation

JoviDeCroock
Copy link
Member

This will enable pika to run

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awww yesss 👍 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 97.749% when pulling b72b648 on add-pkg-lock into cf635d5 on master.

@marvinhagemeister marvinhagemeister merged commit 6037c58 into master Jan 16, 2020
@marvinhagemeister marvinhagemeister deleted the add-pkg-lock branch January 16, 2020 21:30
@cristianbote
Copy link
Member

Thinking if we should add a specific node version as well, since different node version would generate different hashes. I remember this would pop-up from time to time. Is still happening?

outofambit added a commit to outofambit/preact that referenced this pull request Jan 16, 2020
This reverts commit 6037c58, reversing
changes made to cf635d5.
porfirioribeiro pushed a commit to porfirioribeiro/preact that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants