Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CONTRIBUTINIG + comments #2277

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Improve CONTRIBUTINIG + comments #2277

merged 2 commits into from
Jan 24, 2020

Conversation

marvinhagemeister
Copy link
Member

Based on the feedback in Part 2 of this youtube series 👍

@github-actions
Copy link

Size Change: 0 B

Total Size: 38.2 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 2.95 kB 0 B
compat/dist/compat.module.js 2.97 kB 0 B
compat/dist/compat.umd.js 3 kB 0 B
debug/dist/debug.js 3.08 kB 0 B
debug/dist/debug.module.js 3.07 kB 0 B
debug/dist/debug.umd.js 3.14 kB 0 B
devtools/dist/devtools.js 175 B 0 B
devtools/dist/devtools.module.js 185 B 0 B
devtools/dist/devtools.umd.js 252 B 0 B
dist/preact.js 3.69 kB 0 B
dist/preact.min.js 3.69 kB 0 B
dist/preact.module.js 3.71 kB 0 B
dist/preact.umd.js 3.75 kB 0 B
hooks/dist/hooks.js 1.06 kB 0 B
hooks/dist/hooks.module.js 1.08 kB 0 B
hooks/dist/hooks.umd.js 1.12 kB 0 B
test-utils/dist/testUtils.js 390 B 0 B
test-utils/dist/testUtils.module.js 392 B 0 B
test-utils/dist/testUtils.umd.js 469 B 0 B

compressed-size-action

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, loving this feedback! Marvin you're a total champion for following up this quickly

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.807% when pulling 6b473c2 on contributing-2 into c3b977b on master.

@marvinhagemeister marvinhagemeister merged commit 8164289 into master Jan 24, 2020
@marvinhagemeister marvinhagemeister deleted the contributing-2 branch January 24, 2020 15:08
porfirioribeiro pushed a commit to porfirioribeiro/preact that referenced this pull request Feb 3, 2020
Improve CONTRIBUTINIG + comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants