-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failing test by defaulting to empty array #2353
fix failing test by defaulting to empty array #2353
Conversation
Size Change: +30 B (0%) Total Size: 38.5 kB
ℹ️ View Unchanged
|
Just realized I messed up one of the tests in my branch. Rebase on top to see if everything still passes |
bb520d4
to
1e8cbed
Compare
@andrewiggins I found another fix which works on the rebased branch |
? tmp.props.children | ||
: Array.isArray(tmp) | ||
? tmp | ||
: [tmp]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we [null]
it
No description provided.