Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat: Add isDefaultPrevented fn to event #2377

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Compat: Add isDefaultPrevented fn to event #2377

merged 2 commits into from
Feb 28, 2020

Conversation

teodragovic
Copy link
Contributor

@teodragovic teodragovic commented Feb 28, 2020 •
edited
Loading

Fixes: #2374

Hi all 👋 Love the project and wanted to contribute back. This looked simple enough for first PR but LMK if I missed something.

@coveralls
Copy link

coveralls commented Feb 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0004%) to 99.791% when pulling 4be97ce on teodragovic:fix/default-prevented into afb350f on preactjs:master.

@marvinhagemeister marvinhagemeister marked this pull request as ready for review February 28, 2020 12:31
marvinhagemeister
marvinhagemeister approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for a great PR 👍 🎉

@marvinhagemeister marvinhagemeister merged commit 066f3d0 into preactjs:master Feb 28, 2020
@JoviDeCroock
Copy link
Member

Hey,

Thanks for the PR, greatly appreciated!

We might want to do this for the other one we're missing too isPropagationStopped.

@reznord
Copy link
Member

reznord commented Feb 28, 2020

Opened a PR for isStoppedPropogaation in #2378

@teodragovic teodragovic deleted the fix/default-prevented branch February 28, 2020 18:57
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock Awaiting requested review from JoviDeCroock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isDefaultPrevented is not a function
5 participants
@teodragovic @coveralls @JoviDeCroock @reznord @marvinhagemeister