Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IS_NON_DIMENSIONAL to compat #2629

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Move IS_NON_DIMENSIONAL to compat #2629

merged 4 commits into from
Jul 16, 2020

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Jul 15, 2020

This PR moves the IS_NON_DIMENSIONAL regex to compat as described here: #2621

@github-actions
Copy link

github-actions bot commented Jul 15, 2020

Size Change: +552 B (1%)

Total Size: 40.8 kB

Filename Size Change
compat/dist/compat.js 3.34 kB +143 B (4%)
compat/dist/compat.module.js 3.36 kB +135 B (4%)
compat/dist/compat.umd.js 3.39 kB +141 B (4%)
debug/dist/debug.js 3.2 kB +204 B (6%) 🔍
debug/dist/debug.module.js 3.18 kB +202 B (6%) 🔍
debug/dist/debug.umd.js 3.29 kB +209 B (6%) 🔍
dist/preact.js 3.88 kB -119 B (3%)
dist/preact.min.js 3.9 kB -125 B (3%)
dist/preact.module.js 3.9 kB -113 B (2%)
dist/preact.umd.js 3.93 kB -125 B (3%)
ℹ️ View Unchanged
Filename Size Change
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
hooks/dist/hooks.js 1.09 kB 0 B
hooks/dist/hooks.module.js 1.11 kB 0 B
hooks/dist/hooks.umd.js 1.17 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.8% when pulling 8d86a49 on css-px into 469da09 on master.

@marvinhagemeister marvinhagemeister changed the base branch from master to v11 July 15, 2020 20:17
compat/src/util.js Outdated Show resolved Hide resolved
@marvinhagemeister marvinhagemeister marked this pull request as ready for review July 16, 2020 16:50
@marvinhagemeister marvinhagemeister changed the title WIP: Move IS_NON_DIMENSIONAL to compat Move IS_NON_DIMENSIONAL to compat Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants