Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations for preact/jsx-runtime #2771

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

developit
Copy link
Member

This improves VNode creation performance by 7%, at the expense of a small size increase for the jsx-runtime entry that should compress away in bundled applications.

@github-actions
Copy link

github-actions bot commented Sep 23, 2020

Size Change: +8 B (0%)

Total Size: 41.5 kB

Filename Size Change
jsx-runtime/dist/jsxRuntime.js 296 B +4 B (1%)
jsx-runtime/dist/jsxRuntime.module.js 305 B +5 B (1%)
jsx-runtime/dist/jsxRuntime.umd.js 373 B -1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.17 kB 0 B
compat/dist/compat.module.js 3.18 kB 0 B
compat/dist/compat.umd.js 3.23 kB 0 B
debug/dist/debug.js 3.09 kB 0 B
debug/dist/debug.module.js 3.09 kB 0 B
debug/dist/debug.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 194 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.1 kB 0 B
hooks/dist/hooks.module.js 1.12 kB 0 B
hooks/dist/hooks.umd.js 1.18 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Sep 23, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 3da86d3 on jsx-runtime-optimizations into e32fc87 on master.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@marvinhagemeister marvinhagemeister merged commit bbf0416 into master Sep 23, 2020
@marvinhagemeister marvinhagemeister deleted the jsx-runtime-optimizations branch September 23, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants