Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bench infra and add tachometer PR reporter #2775

Merged
merged 6 commits into from
Sep 25, 2020

Conversation

andrewiggins
Copy link
Member

  • Convert bench scripts to ESM
  • Add many_updates bench to CI runs
  • Add tachometer-reporter-action to CI workflow
  • Upload npm package to GitHub artifacts
  • Add deopt script to run v8-deopt-viewer against benches

@coveralls
Copy link

coveralls commented Sep 25, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 93831db on upgrade-bench-infra into bbf0416 on master.

@github-actions
Copy link

github-actions bot commented Sep 25, 2020

Size Change: 0 B

Total Size: 41.5 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.17 kB 0 B
compat/dist/compat.module.js 3.18 kB 0 B
compat/dist/compat.umd.js 3.23 kB 0 B
debug/dist/debug.js 3.09 kB 0 B
debug/dist/debug.module.js 3.09 kB 0 B
debug/dist/debug.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 194 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.1 kB 0 B
hooks/dist/hooks.module.js 1.12 kB 0 B
hooks/dist/hooks.umd.js 1.18 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 305 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 373 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Sep 25, 2020

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: 211.67ms - 215.35ms
  • 03_update10th1k_x16: 30.38ms - 32.51ms
  • many_updates: 37.91ms - 40.93ms
  • text_update: 2.99ms - 3.28ms

window.usedJSHeapSize

  • 02_replace1k: 3.59ms - 3.60ms
  • 03_update10th1k_x16: 3.54ms - 3.55ms
  • many_updates: 4.87ms - 4.87ms
  • text_update: 0.85ms - 0.85ms

Results

02_replace1k
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #354
  • Commit: 80ba888

duration

VersionAvg timevs
211.67ms - 215.35ms-

window.usedJSHeapSize

VersionAvg timevs
3.59ms - 3.60ms-
03_update10th1k_x16
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #354
  • Commit: 80ba888

duration

VersionAvg timevs
30.38ms - 32.51ms-

window.usedJSHeapSize

VersionAvg timevs
3.54ms - 3.55ms-
many_updates
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #354
  • Commit: 80ba888

duration

VersionAvg timevs
37.91ms - 40.93ms-

window.usedJSHeapSize

VersionAvg timevs
4.87ms - 4.87ms-
text_update
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #354
  • Commit: 80ba888

duration

VersionAvg timevs
2.99ms - 3.28ms-

window.usedJSHeapSize

VersionAvg timevs
0.85ms - 0.85ms-

tachometer-reporter-action v2 for CI

@andrewiggins
Copy link
Member Author

The comment won't show summary comparisons until we have PRs after this one - we need a build on master that uploads the npm-package artifact to run tachometer against.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 🙌

@marvinhagemeister marvinhagemeister merged commit 59d2f63 into master Sep 25, 2020
@marvinhagemeister marvinhagemeister deleted the upgrade-bench-infra branch September 25, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants