Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jsx-runtime work when using an alias #2805

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 22, 2020

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -4% - +1% (-6.19ms - +2.26ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -2% - +5% (-0.59ms - +1.52ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -10% - +4% (-5.13ms - +2.17ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +3% (-0.13ms - +0.11ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: slower ❌ 0% - 0% (0.00ms - 0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 86.0.4240.75
  • Sample size: 50
  • Built by: CI #416
  • Commit: 18096ca

duration

VersionAvg timevs preact-mastervs preact-local
preact-master165.44ms - 172.59ms-unsure 🔍
-1% - +4%
-2.26ms - +6.19ms
preact-local164.80ms - 169.29msunsure 🔍
-4% - +1%
-6.19ms - +2.26ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.56ms - 3.57ms-faster ✔
0% - 0%
0.00ms - 0.01ms
preact-local3.57ms - 3.57msslower ❌
0% - 0%
0.00ms - 0.01ms
-
03_update10th1k_x16
  • Browser: chrome-headless 86.0.4240.75
  • Sample size: 80
  • Built by: CI #416
  • Commit: 18096ca

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.83ms - 33.29ms-unsure 🔍
-5% - +2%
-1.52ms - +0.59ms
preact-local32.27ms - 33.79msunsure 🔍
-2% - +5%
-0.59ms - +1.52ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.50ms - 3.51ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.50ms - 3.51msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
many_updates
  • Browser: chrome-headless 86.0.4240.75
  • Sample size: 80
  • Built by: CI #416
  • Commit: 18096ca

duration

VersionAvg timevs preact-mastervs preact-local
preact-master46.42ms - 51.61ms-unsure 🔍
-5% - +11%
-2.17ms - +5.13ms
preact-local44.97ms - 50.10msunsure 🔍
-10% - +4%
-5.13ms - +2.17ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 86.0.4240.75
  • Sample size: 50
  • Built by: CI #416
  • Commit: 18096ca

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.26ms - 3.44ms-unsure 🔍
-3% - +4%
-0.11ms - +0.13ms
preact-local3.26ms - 3.42msunsure 🔍
-4% - +3%
-0.13ms - +0.11ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.82ms - 0.82msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoosh! totally hadn't thought of this one. we'll also need to update @preactjs/compat.

@github-actions
Copy link

Size Change: 0 B

Total Size: 41.6 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.18 kB 0 B
compat/dist/compat.module.js 3.19 kB 0 B
compat/dist/compat.umd.js 3.24 kB 0 B
debug/dist/debug.js 3.12 kB 0 B
debug/dist/debug.module.js 3.11 kB 0 B
debug/dist/debug.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 184 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.1 kB 0 B
hooks/dist/hooks.module.js 1.12 kB 0 B
hooks/dist/hooks.umd.js 1.18 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 305 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 373 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7c87789 on jsx-runtime-with-react-alias into 080bc19 on master.

@marvinhagemeister marvinhagemeister merged commit 415a5ca into master Oct 22, 2020
@marvinhagemeister marvinhagemeister deleted the jsx-runtime-with-react-alias branch October 22, 2020 15:09
@rayriffy
Copy link

When this will be realesed in preact? I would love to use it with Next and React 17. 🧑‍🔬

@mwskwong
Copy link

mwskwong commented Nov 2, 2020

When this will be realesed in preact? I would love to use it with Next and React 17. 🧑‍🔬

Same, I'm wondering when will a stable release be available.

@shilangyu
Copy link

@JoviDeCroock does this actually work? This file does not seem to be included when installing preact:

image

So aliasing react to preact/compat makes react/jsx-runtime point to preact/compat/jsx-runtime which does not exist.

PS. yes, I am on the newly released version:

image

@marvinhagemeister
Copy link
Member

@shilangyu Looks like we forgot to add them to our publish step. Made #2827 to address this. We'll cut a new release once that's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants