Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add displayName to context #2820

Merged
merged 1 commit into from Nov 8, 2020
Merged

Add displayName to context #2820

merged 1 commit into from Nov 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2020

#2454 added support for context displayName.

The type definition is lacking the displayName property too.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9d6023c on max-voronov:context-displayname-typescript into 78bea78 on preactjs:master.

marvinhagemeister
marvinhagemeister approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you so much for your PR 🎉

@marvinhagemeister marvinhagemeister merged commit 1e9e8f9 into preactjs:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @marvinhagemeister