Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmarks #2865

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Update benchmarks #2865

merged 3 commits into from
Dec 15, 2020

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Dec 13, 2020 •
edited
Loading

  • Add create10k and hydrate1k benchmark
  • Track all run timings in replace1k
  • Setup infra to customize measures per benchmark
  • Update tachometer and v8-deopt-viewer

@andrewiggins
Update benchmarks
45b2ea1 
* Add create10k and hydrate1k benchmark
* Track all run timings in replace1k
* Setup infra to customize measures per benchmark
* Update some tachometer and v8-deopt-viewer
@github-actions
Copy link

github-actions bot commented Dec 13, 2020 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +0% (-1.82ms - +0.73ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +4% (-1.47ms - +1.19ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-5.91ms - +9.48ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-2.23ms - +0.57ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -8% - +5% (-3.09ms - +1.97ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.66
  • Sample size: 80
  • Built by: CI #566

  • Commit: af6c86d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master153.05ms - 154.97ms-unsure 🔍
-0% - +1%
-0.73ms - +1.82ms
preact-local152.62ms - 154.29msunsure 🔍
-1% - +0%
-1.82ms - +0.73ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.61ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master55.57ms - 56.20ms-unsure 🔍
-1% - +1%
-0.77ms - +0.29ms
preact-local55.70ms - 56.54msunsure 🔍
-1% - +1%
-0.29ms - +0.77ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master87.59ms - 88.76ms-unsure 🔍
-1% - +1%
-0.67ms - +0.85ms
preact-local87.61ms - 88.57msunsure 🔍
-1% - +1%
-0.85ms - +0.67ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master100.39ms - 102.79ms-unsure 🔍
-2% - +2%
-1.54ms - +1.59ms
preact-local100.55ms - 102.57msunsure 🔍
-2% - +2%
-1.59ms - +1.54ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master55.28ms - 56.92ms-unsure 🔍
-3% - +1%
-1.56ms - +0.65ms
preact-local55.82ms - 57.29msunsure 🔍
-1% - +3%
-0.65ms - +1.56ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master98.63ms - 104.33ms-unsure 🔍
-7% - +0%
-7.42ms - +0.46ms
preact-local102.24ms - 107.68msunsure 🔍
-1% - +7%
-0.46ms - +7.42ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master55.61ms - 56.60ms-unsure 🔍
-1% - +2%
-0.36ms - +0.97ms
preact-local55.35ms - 56.24msunsure 🔍
-2% - +1%
-0.97ms - +0.36ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.66
  • Sample size: 90
  • Built by: CI #566

  • Commit: af6c86d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.66ms - 31.65ms-unsure 🔍
-4% - +5%
-1.19ms - +1.47ms
preact-local29.63ms - 31.40msunsure 🔍
-5% - +4%
-1.47ms - +1.19ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.66
  • Sample size: 50
  • Built by: CI #566

  • Commit: af6c86d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1540.07ms - 1550.33ms-unsure 🔍
-1% - +0%
-9.48ms - +5.91ms
preact-local1541.25ms - 1552.72msunsure 🔍
-0% - +1%
-5.91ms - +9.48ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.66
  • Sample size: 50
  • Built by: CI #566

  • Commit: af6c86d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master151.14ms - 153.22ms-unsure 🔍
-0% - +1%
-0.57ms - +2.23ms
preact-local150.41ms - 152.28msunsure 🔍
-1% - +0%
-2.23ms - +0.57ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.21ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local6.19ms - 6.21msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.66
  • Sample size: 80
  • Built by: CI #566

  • Commit: af6c86d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master35.21ms - 38.86ms-unsure 🔍
-5% - +9%
-1.97ms - +3.09ms
preact-local34.72ms - 38.23msunsure 🔍
-8% - +5%
-3.09ms - +1.97ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.66
  • Sample size: 50
  • Built by: CI #566

  • Commit: af6c86d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.89ms - 2.93ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-local2.90ms - 2.92msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

coveralls commented Dec 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 337e00d on update-bench-scripts-2 into 5ac1684 on master.

@github-actions
Copy link

github-actions bot commented Dec 13, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 41.9 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.23 kB 0 B
compat/dist/compat.module.js 3.23 kB 0 B
compat/dist/compat.umd.js 3.28 kB 0 B
debug/dist/debug.js 3.12 kB 0 B
debug/dist/debug.module.js 3.11 kB 0 B
debug/dist/debug.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.04 kB 0 B
dist/preact.module.js 4.03 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@andrewiggins andrewiggins mentioned this pull request Dec 13, 2020
Merged
marvinhagemeister
marvinhagemeister approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic 🙌

@andrewiggins andrewiggins merged commit 1a0837f into master Dec 15, 2020
@andrewiggins andrewiggins deleted the update-bench-scripts-2 branch December 15, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewiggins @coveralls @marvinhagemeister