Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console.log not showing up in browser #2900

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Fix console.log not showing up in browser #2900

merged 2 commits into from
Jan 2, 2021

Conversation

marvinhagemeister
Copy link
Member

This fixes a regression introduced in #2893 😬

@github-actions
Copy link

github-actions bot commented Jan 2, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +3% (-2.46ms - +5.38ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -1% - +6% (-0.44ms - +2.10ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +2% (-15.48ms - +33.62ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +4% (-0.36ms - +1.53ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +2% (-2.48ms - +3.80ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -7% - +6% (-2.57ms - +2.31ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +5% (-0.04ms - +0.17ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 70
  • Built by: CI #648

  • Commit: f5e25ff

duration

VersionAvg timevs preact-mastervs preact-local
preact-master211.44ms - 217.30ms-unsure 🔍
-2% - +1%
-5.38ms - +2.46ms
preact-local213.23ms - 218.43msunsure 🔍
-1% - +3%
-2.46ms - +5.38ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.60ms - 3.60msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master76.60ms - 78.91ms-unsure 🔍
-3% - +1%
-2.33ms - +0.63ms
preact-local77.68ms - 79.53msunsure 🔍
-1% - +3%
-0.63ms - +2.33ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master118.35ms - 121.15ms-unsure 🔍
-2% - +2%
-2.31ms - +1.84ms
preact-local118.45ms - 121.52msunsure 🔍
-2% - +2%
-1.84ms - +2.31ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master135.64ms - 140.33ms-unsure 🔍
-2% - +2%
-2.71ms - +3.27ms
preact-local135.84ms - 139.57msunsure 🔍
-2% - +2%
-3.27ms - +2.71ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master79.79ms - 82.46ms-unsure 🔍
-3% - +2%
-2.20ms - +1.71ms
preact-local79.94ms - 82.79msunsure 🔍
-2% - +3%
-1.71ms - +2.20ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master148.53ms - 155.02ms-unsure 🔍
-4% - +2%
-6.44ms - +2.49ms
preact-local150.69ms - 156.82msunsure 🔍
-2% - +4%
-2.49ms - +6.44ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master81.48ms - 84.57ms-unsure 🔍
-1% - +4%
-0.64ms - +3.24ms
preact-local80.56ms - 82.90msunsure 🔍
-4% - +1%
-3.24ms - +0.64ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 120
  • Built by: CI #648

  • Commit: f5e25ff

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.01ms - 34.75ms-unsure 🔍
-6% - +1%
-2.10ms - +0.44ms
preact-local33.78ms - 35.63msunsure 🔍
-1% - +6%
-0.44ms - +2.10ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #648

  • Commit: f5e25ff

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2086.88ms - 2114.26ms-unsure 🔍
-2% - +1%
-33.62ms - +15.48ms
preact-local2089.27ms - 2130.01msunsure 🔍
-1% - +2%
-15.48ms - +33.62ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #648

  • Commit: f5e25ff

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.72ms - 34.81ms-unsure 🔍
-4% - +1%
-1.53ms - +0.36ms
preact-local34.08ms - 35.62msunsure 🔍
-1% - +4%
-0.36ms - +1.53ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #648

  • Commit: f5e25ff

duration

VersionAvg timevs preact-mastervs preact-local
preact-master177.51ms - 181.83ms-unsure 🔍
-2% - +1%
-3.80ms - +2.48ms
preact-local178.05ms - 182.61msunsure 🔍
-1% - +2%
-2.48ms - +3.80ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.19ms - 6.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #648

  • Commit: f5e25ff

duration

VersionAvg timevs preact-mastervs preact-local
preact-master36.83ms - 40.39ms-unsure 🔍
-6% - +7%
-2.31ms - +2.57ms
preact-local36.80ms - 40.15msunsure 🔍
-7% - +6%
-2.57ms - +2.31ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 90
  • Built by: CI #648

  • Commit: f5e25ff

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.44ms - 3.57ms-unsure 🔍
-5% - +1%
-0.17ms - +0.04ms
preact-local3.49ms - 3.65msunsure 🔍
-1% - +5%
-0.04ms - +0.17ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

coveralls commented Jan 2, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 99.609% when pulling f08538e on fix-console-logs into 09c2b8e on master.

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Size Change: 0 B

Total Size: 41.6 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.23 kB 0 B
compat/dist/compat.module.js 3.25 kB 0 B
compat/dist/compat.umd.js 3.29 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.03 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 99362ac into master Jan 2, 2021
@marvinhagemeister marvinhagemeister deleted the fix-console-logs branch January 2, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @coveralls @andrewiggins