Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure expression is not marked for removal #2905

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Ensure expression is not marked for removal #2905

merged 1 commit into from
Jan 3, 2021

Conversation

marvinhagemeister
Copy link
Member

I'm currently playing around with different test runners based on Rollup and ESBuild. They detect the expression in our test as being unused and will eliminate them automatically. This leads to this test to fail. By storing them in an array and ensuring we read from it once, we can circumvent that.

@marvinhagemeister
Ensure expression is not marked for removal
920f923 
Different test runners detect these experessions as unused and will
remove them.
@github-actions
Copy link

github-actions bot commented Jan 3, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +2% (-2.24ms - +2.80ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +4% (-1.39ms - +1.45ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-4.37ms - +2.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +1% (-0.54ms - +0.18ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-2.02ms - +0.39ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -9% - +4% (-2.95ms - +1.47ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +3% (-0.18ms - +0.13ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.02ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #657

  • Commit: a9f638f

duration

VersionAvg timevs preact-mastervs preact-local
preact-master179.74ms - 183.44ms-unsure 🔍
-2% - +1%
-2.80ms - +2.24ms
preact-local180.17ms - 183.58msunsure 🔍
-1% - +2%
-2.24ms - +2.80ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master68.40ms - 70.33ms-unsure 🔍
-2% - +2%
-1.35ms - +1.28ms
preact-local68.51ms - 70.30msunsure 🔍
-2% - +2%
-1.28ms - +1.35ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master103.84ms - 105.76ms-unsure 🔍
-3% - +0%
-3.00ms - +0.34ms
preact-local104.76ms - 107.50msunsure 🔍
-0% - +3%
-0.34ms - +3.00ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master120.60ms - 123.24ms-unsure 🔍
-1% - +3%
-1.04ms - +3.55ms
preact-local118.79ms - 122.54msunsure 🔍
-3% - +1%
-3.55ms - +1.04ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master65.20ms - 66.46ms-unsure 🔍
-2% - +2%
-1.24ms - +1.43ms
preact-local64.55ms - 66.91msunsure 🔍
-2% - +2%
-1.43ms - +1.24ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master121.85ms - 128.56ms-unsure 🔍
-3% - +5%
-3.97ms - +5.87ms
preact-local120.65ms - 127.85msunsure 🔍
-5% - +3%
-5.87ms - +3.97ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master64.40ms - 66.69ms-unsure 🔍
-2% - +3%
-1.11ms - +1.70ms
preact-local64.44ms - 66.07msunsure 🔍
-3% - +2%
-1.70ms - +1.11ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 70
  • Built by: CI #657

  • Commit: a9f638f

duration

VersionAvg timevs preact-mastervs preact-local
preact-master32.26ms - 34.28ms-unsure 🔍
-4% - +4%
-1.45ms - +1.39ms
preact-local32.31ms - 34.30msunsure 🔍
-4% - +4%
-1.39ms - +1.45ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #657

  • Commit: a9f638f

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1454.06ms - 1457.91ms-unsure 🔍
-0% - +0%
-2.00ms - +4.37ms
preact-local1452.27ms - 1457.33msunsure 🔍
-0% - +0%
-4.37ms - +2.00ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #657

  • Commit: a9f638f

duration

VersionAvg timevs preact-mastervs preact-local
preact-master25.94ms - 26.47ms-unsure 🔍
-1% - +2%
-0.18ms - +0.54ms
preact-local25.78ms - 26.27msunsure 🔍
-2% - +1%
-0.54ms - +0.18ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #657

  • Commit: a9f638f

duration

VersionAvg timevs preact-mastervs preact-local
preact-master145.67ms - 147.21ms-unsure 🔍
-0% - +1%
-0.39ms - +2.02ms
preact-local144.70ms - 146.56msunsure 🔍
-1% - +0%
-2.02ms - +0.39ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
-0% - +0%
-0.02ms - +0.00ms
preact-local6.19ms - 6.22msunsure 🔍
-0% - +0%
-0.00ms - +0.02ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #657

  • Commit: a9f638f

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.58ms - 34.86ms-unsure 🔍
-5% - +9%
-1.47ms - +2.95ms
preact-local30.99ms - 33.96msunsure 🔍
-9% - +4%
-2.95ms - +1.47ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 60
  • Built by: CI #657

  • Commit: a9f638f

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.57ms - 3.86ms-unsure 🔍
-3% - +5%
-0.13ms - +0.18ms
preact-local3.64ms - 3.74msunsure 🔍
-5% - +3%
-0.18ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.609% when pulling 920f923 on ensure-expression into 6ea2d55 on master.

@github-actions
Copy link

github-actions bot commented Jan 3, 2021

Size Change: 0 B

Total Size: 41.6 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.23 kB 0 B
compat/dist/compat.module.js 3.25 kB 0 B
compat/dist/compat.umd.js 3.29 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.03 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit ef3d54c into master Jan 3, 2021
@marvinhagemeister marvinhagemeister deleted the ensure-expression branch January 3, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @coveralls @JoviDeCroock