Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel-loader #2911

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Remove babel-loader #2911

merged 1 commit into from
Jan 5, 2021

Conversation

andrewiggins
Copy link
Member

We are no longer using webpack for tests so we no longer need this dep either

We are no longer using webpack for tests so we no longer need this dep either
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +1% (-3.00ms - +1.32ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -6% - +0% (-2.09ms - +0.13ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-22.01ms - +13.55ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +3% (-0.21ms - +0.68ms)
    preact-local vs preact-master
  • hydrate1k: slower ❌ 0% - 2% (0.10ms - 2.80ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +10% (-1.10ms - +3.45ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +4% (-0.14ms - +0.14ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 70
  • Built by: CI #675
  • Commit: 9fc9879

duration

VersionAvg timevs preact-mastervs preact-local
preact-master221.15ms - 224.56ms-unsure 🔍
-1% - +1%
-1.32ms - +3.00ms
preact-local220.70ms - 223.34msunsure 🔍
-1% - +1%
-3.00ms - +1.32ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.60ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master82.31ms - 83.87ms-faster ✔
0% - 4%
0.16ms - 3.06ms
preact-local83.48ms - 85.92msslower ❌
0% - 4%
0.16ms - 3.06ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master122.66ms - 125.75ms-unsure 🔍
-2% - +2%
-1.92ms - +2.11ms
preact-local122.82ms - 125.40msunsure 🔍
-2% - +2%
-2.11ms - +1.92ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master140.94ms - 143.53ms-unsure 🔍
-0% - +2%
-0.63ms - +2.69ms
preact-local140.16ms - 142.24msunsure 🔍
-2% - +0%
-2.69ms - +0.63ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master80.66ms - 82.37ms-unsure 🔍
-2% - +1%
-1.92ms - +0.60ms
preact-local81.24ms - 83.10msunsure 🔍
-1% - +2%
-0.60ms - +1.92ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master155.64ms - 159.80ms-unsure 🔍
-2% - +2%
-2.97ms - +2.88ms
preact-local155.71ms - 159.82msunsure 🔍
-2% - +2%
-2.88ms - +2.97ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master80.90ms - 82.56ms-unsure 🔍
-1% - +2%
-1.09ms - +1.34ms
preact-local80.72ms - 82.49msunsure 🔍
-2% - +1%
-1.34ms - +1.09ms
-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 120
  • Built by: CI #675
  • Commit: 9fc9879

duration

VersionAvg timevs preact-mastervs preact-local
preact-master34.83ms - 36.42ms-unsure 🔍
-0% - +6%
-0.13ms - +2.09ms
preact-local33.87ms - 35.42msunsure 🔍
-6% - +0%
-2.09ms - +0.13ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.52ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #675
  • Commit: 9fc9879

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2014.40ms - 2038.53ms-unsure 🔍
-1% - +1%
-13.55ms - +22.01ms
preact-local2009.18ms - 2035.29msunsure 🔍
-1% - +1%
-22.01ms - +13.55ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #675
  • Commit: 9fc9879

duration

VersionAvg timevs preact-mastervs preact-local
preact-master24.96ms - 25.56ms-unsure 🔍
-3% - +1%
-0.68ms - +0.21ms
preact-local25.16ms - 25.83msunsure 🔍
-1% - +3%
-0.21ms - +0.68ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #675
  • Commit: 9fc9879

duration

VersionAvg timevs preact-mastervs preact-local
preact-master131.72ms - 133.85ms-faster ✔
0% - 2%
0.10ms - 2.80ms
preact-local133.41ms - 135.06msslower ❌
0% - 2%
0.10ms - 2.80ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.23ms-unsure 🔍
-0% - +1%
-0.01ms - +0.03ms
preact-local6.19ms - 6.21msunsure 🔍
-1% - +0%
-0.03ms - +0.01ms
-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #675
  • Commit: 9fc9879

duration

VersionAvg timevs preact-mastervs preact-local
preact-master34.44ms - 37.43ms-unsure 🔍
-9% - +3%
-3.45ms - +1.10ms
preact-local35.39ms - 38.82msunsure 🔍
-3% - +10%
-1.10ms - +3.45ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 160
  • Built by: CI #675
  • Commit: 9fc9879

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.39ms - 3.61ms-unsure 🔍
-4% - +4%
-0.14ms - +0.14ms
preact-local3.41ms - 3.58msunsure 🔍
-4% - +4%
-0.14ms - +0.14ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.609% when pulling fbc842e on remove-babel-loader into d29d858 on master.

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Size Change: 0 B

Total Size: 41.7 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.24 kB 0 B
compat/dist/compat.module.js 3.25 kB 0 B
compat/dist/compat.umd.js 3.29 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.04 kB 0 B
dist/preact.min.js 4.07 kB 0 B
dist/preact.module.js 4.06 kB 0 B
dist/preact.umd.js 4.11 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 1a077a7 into master Jan 5, 2021
@JoviDeCroock JoviDeCroock deleted the remove-babel-loader branch January 5, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants