Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sinon dependencies to fix IE11 Promise error #2922

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

marvinhagemeister
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 12, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +1% (-2.19ms - +1.11ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -6% - +0% (-2.03ms - +0.18ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +0% (-8.67ms - +3.75ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +2% (-0.91ms - +0.67ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-1.63ms - +1.50ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -6% - +7% (-1.80ms - +2.15ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +4% (-0.16ms - +0.16ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.03ms - +0.02ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #695
  • Commit: c0ca561

duration

VersionAvg timevs preact-mastervs preact-local
preact-master168.45ms - 170.63ms-unsure 🔍
-1% - +1%
-1.11ms - +2.19ms
preact-local167.76ms - 170.24msunsure 🔍
-1% - +1%
-2.19ms - +1.11ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-local3.60ms - 3.61msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master64.28ms - 65.36ms-unsure 🔍
-1% - +1%
-0.70ms - +0.74ms
preact-local64.32ms - 65.27msunsure 🔍
-1% - +1%
-0.74ms - +0.70ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master100.12ms - 101.53ms-unsure 🔍
-1% - +1%
-0.80ms - +1.21ms
preact-local99.90ms - 101.34msunsure 🔍
-1% - +1%
-1.21ms - +0.80ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master115.08ms - 116.66ms-unsure 🔍
-2% - +0%
-2.30ms - +0.29ms
preact-local115.85ms - 117.90msunsure 🔍
-0% - +2%
-0.29ms - +2.30ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master62.23ms - 63.22ms-unsure 🔍
-2% - +1%
-0.96ms - +0.52ms
preact-local62.39ms - 63.49msunsure 🔍
-1% - +2%
-0.52ms - +0.96ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master117.55ms - 122.93ms-unsure 🔍
-3% - +4%
-3.39ms - +4.65ms
preact-local116.63ms - 122.60msunsure 🔍
-4% - +3%
-4.65ms - +3.39ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master61.80ms - 62.62ms-unsure 🔍
-1% - +1%
-0.40ms - +0.81ms
preact-local61.56ms - 62.45msunsure 🔍
-1% - +1%
-0.81ms - +0.40ms
-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 120
  • Built by: CI #695
  • Commit: c0ca561

duration

VersionAvg timevs preact-mastervs preact-local
preact-master34.36ms - 35.99ms-unsure 🔍
-1% - +6%
-0.18ms - +2.03ms
preact-local33.50ms - 35.00msunsure 🔍
-6% - +0%
-2.03ms - +0.18ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #695
  • Commit: c0ca561

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1668.08ms - 1677.46ms-unsure 🔍
-0% - +1%
-3.75ms - +8.67ms
preact-local1666.24ms - 1674.38msunsure 🔍
-1% - +0%
-8.67ms - +3.75ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #695
  • Commit: c0ca561

duration

VersionAvg timevs preact-mastervs preact-local
preact-master27.92ms - 29.17ms-unsure 🔍
-2% - +3%
-0.67ms - +0.91ms
preact-local27.94ms - 28.91msunsure 🔍
-3% - +2%
-0.91ms - +0.67ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #695
  • Commit: c0ca561

duration

VersionAvg timevs preact-mastervs preact-local
preact-master140.16ms - 142.32ms-unsure 🔍
-1% - +1%
-1.50ms - +1.63ms
preact-local140.04ms - 142.31msunsure 🔍
-1% - +1%
-1.63ms - +1.50ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.23ms-unsure 🔍
-0% - +0%
-0.02ms - +0.03ms
preact-local6.19ms - 6.22msunsure 🔍
-0% - +0%
-0.03ms - +0.02ms
-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #695
  • Commit: c0ca561

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.96ms - 33.71ms-unsure 🔍
-7% - +6%
-2.15ms - +1.80ms
preact-local31.09ms - 33.93msunsure 🔍
-6% - +7%
-1.80ms - +2.15ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 130
  • Built by: CI #695
  • Commit: c0ca561

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.65ms - 3.82ms-unsure 🔍
-4% - +4%
-0.16ms - +0.16ms
preact-local3.60ms - 3.88msunsure 🔍
-4% - +4%
-0.16ms - +0.16ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.615% when pulling 4ae2178 on update-sinon into bd38929 on master.

@github-actions
Copy link

Size Change: 0 B

Total Size: 42 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.34 kB 0 B
compat/dist/compat.module.js 3.33 kB 0 B
compat/dist/compat.umd.js 3.39 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.04 kB 0 B
dist/preact.min.js 4.07 kB 0 B
dist/preact.module.js 4.06 kB 0 B
dist/preact.umd.js 4.11 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit a8cd5ae into master Jan 12, 2021
@marvinhagemeister marvinhagemeister deleted the update-sinon branch January 12, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants