Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix karma IE11 target containing ES2015 syntax #2923

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

marvinhagemeister
Copy link
Member

This should resolve the remaining issues with our new test setup for IE11. Turns out that the build target was always overwritten in karma-esbuild and we need to set it to es5 to ensure that the bundler module code doesn't use arrow functions. This threw with kolorist as that exposed ES2015+ code in its module entry in package.json.

With all this done I can't find any syntax feature in our bundled test fails that fail in IE11 anymore 👍

@github-actions
Copy link

github-actions bot commented Jan 12, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +3% (-3.80ms - +6.43ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -3% - +7% (-0.91ms - +2.26ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-5.10ms - +18.04ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +0% (-0.76ms - +0.06ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +2% (-3.42ms - +3.17ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +10% (-1.05ms - +3.84ms)
    preact-local vs preact-master
  • text_update: faster ✔ 0% - 1% (0.00ms - 0.04ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 70
  • Built by: CI #699
  • Commit: 72da820

duration

VersionAvg timevs preact-mastervs preact-local
preact-master199.42ms - 206.48ms-unsure 🔍
-3% - +2%
-6.43ms - +3.80ms
preact-local200.56ms - 207.97msunsure 🔍
-2% - +3%
-3.80ms - +6.43ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master72.25ms - 74.23ms-unsure 🔍
-3% - +1%
-2.38ms - +0.67ms
preact-local72.93ms - 75.26msunsure 🔍
-1% - +3%
-0.67ms - +2.38ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master118.40ms - 121.86ms-unsure 🔍
-1% - +3%
-1.25ms - +3.61ms
preact-local117.24ms - 120.65msunsure 🔍
-3% - +1%
-3.61ms - +1.25ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master131.49ms - 135.71ms-unsure 🔍
-1% - +4%
-1.89ms - +4.78ms
preact-local129.58ms - 134.74msunsure 🔍
-4% - +1%
-4.78ms - +1.89ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master75.68ms - 79.50ms-unsure 🔍
-2% - +5%
-1.72ms - +3.52ms
preact-local74.90ms - 78.48msunsure 🔍
-5% - +2%
-3.52ms - +1.72ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master138.02ms - 145.23ms-unsure 🔍
-5% - +2%
-7.78ms - +3.09ms
preact-local139.89ms - 148.04msunsure 🔍
-2% - +6%
-3.09ms - +7.78ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master74.75ms - 77.56ms-unsure 🔍
-3% - +2%
-2.33ms - +1.71ms
preact-local75.02ms - 77.92msunsure 🔍
-2% - +3%
-1.71ms - +2.33ms
-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 130
  • Built by: CI #699
  • Commit: 72da820

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.61ms - 32.99ms-unsure 🔍
-7% - +3%
-2.26ms - +0.91ms
preact-local31.43ms - 33.52msunsure 🔍
-3% - +7%
-0.91ms - +2.26ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.53ms - 3.53msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #699
  • Commit: 72da820

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1676.87ms - 1691.59ms-unsure 🔍
-1% - +0%
-18.04ms - +5.10ms
preact-local1681.78ms - 1699.62msunsure 🔍
-0% - +1%
-5.10ms - +18.04ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #699
  • Commit: 72da820

duration

VersionAvg timevs preact-mastervs preact-local
preact-master26.33ms - 26.97ms-unsure 🔍
-0% - +3%
-0.06ms - +0.76ms
preact-local26.04ms - 26.55msunsure 🔍
-3% - +0%
-0.76ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #699
  • Commit: 72da820

duration

VersionAvg timevs preact-mastervs preact-local
preact-master142.11ms - 146.70ms-unsure 🔍
-2% - +2%
-3.17ms - +3.42ms
preact-local141.91ms - 146.65msunsure 🔍
-2% - +2%
-3.42ms - +3.17ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.21ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local6.19ms - 6.19msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #699
  • Commit: 72da820

duration

VersionAvg timevs preact-mastervs preact-local
preact-master36.85ms - 40.00ms-unsure 🔍
-10% - +3%
-3.84ms - +1.05ms
preact-local37.96ms - 41.70msunsure 🔍
-3% - +10%
-1.05ms - +3.84ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #699
  • Commit: 72da820

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.99ms - 3.02ms-slower ❌
0% - 1%
0.00ms - 0.04ms
preact-local2.97ms - 2.99msfaster ✔
0% - 1%
0.00ms - 0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.615% when pulling a0a4bea on esbuild-ie11 into a8cd5ae on master.

@github-actions
Copy link

Size Change: 0 B

Total Size: 42 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.34 kB 0 B
compat/dist/compat.module.js 3.33 kB 0 B
compat/dist/compat.umd.js 3.39 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.04 kB 0 B
dist/preact.min.js 4.07 kB 0 B
dist/preact.module.js 4.06 kB 0 B
dist/preact.umd.js 4.11 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 12d8182 into master Jan 12, 2021
@marvinhagemeister marvinhagemeister deleted the esbuild-ie11 branch January 12, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants