Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case setting contentEditable to false #2938

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add test case setting contentEditable to false #2938

merged 1 commit into from
Jan 19, 2021

Conversation

marvinhagemeister
Copy link
Member

Missed in my last PR that false has a special meaning, similar to aria attributes.

Fixes #2926 .

@github-actions
Copy link

github-actions bot commented Jan 18, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: faster ✔ 0% - 2% (0.19ms - 4.45ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -7% - +3% (-2.07ms - +0.96ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-14.94ms - +28.71ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -5% - +1% (-1.61ms - +0.32ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-0.80ms - +0.32ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -7% - +7% (-2.83ms - +2.72ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #746

  • Commit: f526d29

duration

VersionAvg timevs preact-mastervs preact-local
preact-master179.97ms - 183.23ms-slower ❌
0% - 2%
0.19ms - 4.45ms
preact-local177.91ms - 180.65msfaster ✔
0% - 2%
0.19ms - 4.45ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.59ms - 3.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master66.75ms - 68.37ms-unsure 🔍
-2% - +2%
-1.02ms - +1.07ms
preact-local66.87ms - 68.19msunsure 🔍
-2% - +2%
-1.07ms - +1.02ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master102.90ms - 104.73ms-unsure 🔍
-1% - +1%
-1.22ms - +1.23ms
preact-local103.00ms - 104.63msunsure 🔍
-1% - +1%
-1.23ms - +1.22ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master120.67ms - 122.93ms-unsure 🔍
-0% - +3%
-0.05ms - +3.65ms
preact-local118.53ms - 121.47msunsure 🔍
-3% - +0%
-3.65ms - +0.05ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master65.38ms - 66.44ms-unsure 🔍
-2% - +1%
-1.33ms - +0.82ms
preact-local65.23ms - 67.10msunsure 🔍
-1% - +2%
-0.82ms - +1.33ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master131.06ms - 134.40ms-unsure 🔍
-0% - +3%
-0.44ms - +4.48ms
preact-local128.91ms - 132.51msunsure 🔍
-3% - +0%
-4.48ms - +0.44ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master64.79ms - 66.34ms-unsure 🔍
-0% - +3%
-0.03ms - +1.99ms
preact-local63.93ms - 65.24msunsure 🔍
-3% - +0%
-1.99ms - +0.03ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 130
  • Built by: CI #746

  • Commit: f526d29

duration

VersionAvg timevs preact-mastervs preact-local
preact-master28.62ms - 30.78ms-unsure 🔍
-3% - +7%
-0.96ms - +2.07ms
preact-local28.08ms - 30.20msunsure 🔍
-7% - +3%
-2.07ms - +0.96ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.51ms - 3.52ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #746

  • Commit: f526d29

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1958.08ms - 1985.48ms-unsure 🔍
-1% - +1%
-28.71ms - +14.94ms
preact-local1961.68ms - 1995.66msunsure 🔍
-1% - +1%
-14.94ms - +28.71ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.98ms - 25.98ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.98ms - 25.98msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 70
  • Built by: CI #746

  • Commit: f526d29

duration

VersionAvg timevs preact-mastervs preact-local
preact-master32.24ms - 33.83ms-unsure 🔍
-1% - +5%
-0.32ms - +1.61ms
preact-local31.85ms - 32.93msunsure 🔍
-5% - +1%
-1.61ms - +0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #746

  • Commit: f526d29

duration

VersionAvg timevs preact-mastervs preact-local
preact-master128.85ms - 129.69ms-unsure 🔍
-0% - +1%
-0.32ms - +0.80ms
preact-local128.66ms - 129.40msunsure 🔍
-1% - +0%
-0.80ms - +0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.19ms - 6.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #746

  • Commit: f526d29

duration

VersionAvg timevs preact-mastervs preact-local
preact-master37.99ms - 41.89ms-unsure 🔍
-7% - +7%
-2.72ms - +2.83ms
preact-local37.90ms - 41.86msunsure 🔍
-7% - +7%
-2.83ms - +2.72ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.84ms - 4.84ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.84ms - 4.84msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #746

  • Commit: f526d29

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.89ms - 2.92ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-local2.89ms - 2.92msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@marvinhagemeister marvinhagemeister mentioned this pull request Jan 18, 2021
Closed
@coveralls
Copy link

coveralls commented Jan 18, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 99.438% when pulling 070b1bb on contenteditable-2 into f6c44cd on master.

@github-actions
Copy link

github-actions bot commented Jan 18, 2021 •
edited
Loading

Size Change: 0 B

Total Size: 42 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 3.96 kB 0 B
dist/preact.min.js 3.98 kB 0 B
dist/preact.module.js 3.99 kB 0 B
dist/preact.umd.js 4.03 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@developit
Copy link
Member

developit commented Jan 18, 2021 •
edited by marvinhagemeister
Loading

I think #2939 might support this without the extra 2 custom behaviors (if I can get CI to work).

EDIT: Fixed wrong issue number - @marvinhagemeister

@marvinhagemeister
Copy link
Member Author

@developit Fix was merged with #2939, but let's add the test case from this PR regardless.

@marvinhagemeister marvinhagemeister changed the title Fix unable to set contentEditable to false Add test case setting contentEditable to false Jan 19, 2021
@marvinhagemeister marvinhagemeister merged commit d6438b3 into master Jan 19, 2021
@marvinhagemeister marvinhagemeister deleted the contenteditable-2 branch January 19, 2021 09:43
@developit
Copy link
Member

Good call @marvinhagemeister - I'd meant to copy it over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

element with contentEditable=undefined crashes in Preact but not React
4 participants
@marvinhagemeister @coveralls @developit @JoviDeCroock