Add flushSync to preact-compat #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if there's anything you'd like me to change/update/improve. 🙏 |
developit
approved these changes
Apr 5, 2021
JoviDeCroock
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my attempt to address #2636. I ran into the issue of
flushSyncnot being available when upgrading to the latest version of chakra UI which was added in this PR and was added to address facebook/react#18591 (comment). Hopefully the latter isn't an issue for us.Always the possibility that this doesn't work as expected and we need to enhance it in someway. Without it though, it certainly doesn't work, ha.
Let me know if I need to update anything else.