Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely directly on performance.now #3130

Merged
merged 7 commits into from
Apr 26, 2021
Merged

Conversation

developit
Copy link
Member

@developit developit commented Apr 26, 2021

React doesn't export the scheduler methods or constants from react or react-dom.

@github-actions
Copy link

github-actions bot commented Apr 26, 2021

Size Change: -366 B (0%)

Total Size: 42 kB

Filename Size Change
compat/dist/compat.js 3.39 kB -114 B (3%)
compat/dist/compat.module.js 3.38 kB -135 B (3%)
compat/dist/compat.umd.js 3.44 kB -117 B (3%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
dist/preact.js 3.97 kB 0 B
dist/preact.min.js 4.01 kB 0 B
dist/preact.module.js 4 kB 0 B
dist/preact.umd.js 4.05 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

package.json Outdated Show resolved Hide resolved
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get the CI green and then this is ready to be merged 👍

@marvinhagemeister marvinhagemeister merged commit 84b1331 into master Apr 26, 2021
@marvinhagemeister marvinhagemeister deleted the scheduler-slimdown branch April 26, 2021 20:27
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 98.876% when pulling 068a233 on scheduler-slimdown into ec88035 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants