Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hydrate when we are passing document as the parent #3328

Closed
wants to merge 11 commits into from

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 16, 2021

Coverage Status

Coverage increased (+0.003%) to 99.627% when pulling 2a693c8 on hydrate-compat into 3a32895 on master.

@github-actions
Copy link

github-actions bot commented Nov 16, 2021

Size Change: +160 B (0%)

Total Size: 42.2 kB

Filename Size Change
compat/dist/compat.js 3.49 kB +53 B (1%)
compat/dist/compat.module.js 3.48 kB +54 B (1%)
compat/dist/compat.umd.js 3.54 kB +53 B (1%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
dist/preact.js 3.97 kB 0 B
dist/preact.min.js 4 kB 0 B
dist/preact.module.js 3.99 kB 0 B
dist/preact.umd.js 4.03 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.14 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@@ -10562,6 +10562,8 @@
},
"node_modules/npm-merge-driver/node_modules/ansi-regex": {
"version": "2.1.1",
"resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-2.1.1.tgz",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest npm seems to alter out lockfile

@JoviDeCroock JoviDeCroock deleted the hydrate-compat branch December 1, 2021 22:55
@jfsiii
Copy link

jfsiii commented Dec 21, 2021

@JoviDeCroock I'm interested in this re: remix-run/remix#425. It seems to be the only remaining task. Is this change no longer needed/wanted? Will it be handled in another ticket? Thanks for the work and any information.

@JoviDeCroock
Copy link
Member Author

Looking for a more elegant solution to this in all fairness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants