(fix) - handle hooks that throw during cleanup #3345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a hook throws an error during
cleanup
we want to run all the other cleanups so we can avoid memory leaks and end in a consistent UI.For this we'll need to always clear the
hook._cleanup
function so that we don't call it twice. During unmount we want to ensure we run through all hooks and even if we error we defer that to only bubble up the latest error.fixes #3329