Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate component patching from mounting #3525

Merged
merged 3 commits into from
Jun 5, 2022
Merged

Conversation

JoviDeCroock
Copy link
Member

This is #3519 without the startDom optimization and the rendererState removal

@github-actions
Copy link

github-actions bot commented Apr 28, 2022

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-4.49ms - +1.56ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +6% (-2.34ms - +2.94ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +3% (-14.53ms - +35.62ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -5% - +3% (-50.94ms - +28.89ms)
    preact-local vs preact-master
  • hydrate1k: faster ✔ 4% - 18% (4.92ms - 28.31ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -1% - +8% (-9.12ms - +64.30ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +12% (-1.31ms - +51.63ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -4% - +4% (-1.87ms - +2.11ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: faster ✔ 0% - 1% (0.02ms - 0.04ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: faster ✔ 0% - 1% (0.00ms - 0.04ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.04ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +2% (-0.01ms - +0.05ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.01ms - +0.03ms)
    preact-local vs preact-master
  • text_update: slower ❌ 0% - 2% (0.00ms - 0.02ms)
    preact-local vs preact-master
  • todo: slower ❌ 1% - 1% (0.01ms - 0.01ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master192.46ms - 196.45ms-unsure 🔍
-1% - +2%
-1.56ms - +4.49ms
preact-local190.72ms - 195.26msunsure 🔍
-2% - +1%
-4.49ms - +1.56ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.18ms - 4.20ms-slower ❌
0% - 1%
0.02ms - 0.04ms
preact-local4.15ms - 4.16msfaster ✔
0% - 1%
0.02ms - 0.04ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master61.08ms - 63.28ms-unsure 🔍
-1% - +5%
-0.42ms - +2.78ms
preact-local59.84ms - 62.17msunsure 🔍
-4% - +1%
-2.78ms - +0.42ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master88.62ms - 92.06ms-slower ❌
4% - 10%
3.46ms - 8.42ms
preact-local82.62ms - 86.18msfaster ✔
4% - 9%
3.46ms - 8.42ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master76.35ms - 78.50ms-unsure 🔍
-3% - +1%
-2.23ms - +0.95ms
preact-local76.90ms - 79.24msunsure 🔍
-1% - +3%
-0.95ms - +2.23ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master192.48ms - 196.48ms-unsure 🔍
-1% - +2%
-1.57ms - +4.48ms
preact-local190.76ms - 195.29msunsure 🔍
-2% - +1%
-4.48ms - +1.57ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master49.96ms - 53.84ms-unsure 🔍
-6% - +4%
-2.94ms - +2.34ms
preact-local50.41ms - 53.99msunsure 🔍
-5% - +6%
-2.34ms - +2.94ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.23ms - 4.26ms-slower ❌
0% - 1%
0.00ms - 0.04ms
preact-local4.21ms - 4.24msfaster ✔
0% - 1%
0.00ms - 0.04ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1405.15ms - 1414.34ms-unsure 🔍
-2% - +1%
-35.62ms - +14.53ms
preact-local1395.64ms - 1444.94msunsure 🔍
-1% - +3%
-14.53ms - +35.62ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master28.34ms - 28.39ms-unsure 🔍
-0% - +0%
-0.04ms - +0.02ms
preact-local28.36ms - 28.40msunsure 🔍
-0% - +0%
-0.02ms - +0.04ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master982.32ms - 1040.80ms-unsure 🔍
-3% - +5%
-28.89ms - +50.94ms
preact-local973.36ms - 1027.70msunsure 🔍
-5% - +3%
-50.94ms - +28.89ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master2.12ms - 2.16ms-unsure 🔍
-2% - +0%
-0.05ms - +0.01ms
preact-local2.14ms - 2.18msunsure 🔍
-0% - +2%
-0.01ms - +0.05ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master146.16ms - 160.57ms-slower ❌
3% - 21%
4.92ms - 28.31ms
preact-local127.54ms - 145.97msfaster ✔
4% - 18%
4.92ms - 28.31ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.90ms - 6.91ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-local6.91ms - 6.91msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master777.19ms - 824.21ms-unsure 🔍
-8% - +1%
-64.30ms - +9.12ms
preact-local800.10ms - 856.49msunsure 🔍
-1% - +8%
-9.12ms - +64.30ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master5.72ms - 5.75ms-unsure 🔍
-0% - +0%
-0.03ms - +0.01ms
preact-local5.73ms - 5.76msunsure 🔍
-0% - +0%
-0.01ms - +0.03ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master419.70ms - 452.85ms-unsure 🔍
-11% - +0%
-51.63ms - +1.31ms
preact-local440.80ms - 482.08msunsure 🔍
-0% - +12%
-1.31ms - +51.63ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.30ms - 1.31ms-faster ✔
0% - 2%
0.00ms - 0.02ms
preact-local1.31ms - 1.33msslower ❌
0% - 2%
0.00ms - 0.02ms
-
todo

duration

VersionAvg timevs preact-mastervs preact-local
preact-master45.81ms - 48.60ms-unsure 🔍
-4% - +4%
-2.11ms - +1.87ms
preact-local45.90ms - 48.75msunsure 🔍
-4% - +4%
-1.87ms - +2.11ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.47ms - 1.47ms-faster ✔
1% - 1%
0.01ms - 0.01ms
preact-local1.48ms - 1.48msslower ❌
1% - 1%
0.01ms - 0.01ms
-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Apr 28, 2022

Coverage Status

Coverage increased (+0.01%) to 99.444% when pulling deb91a0 on separate-comp-v2 into 0cab9a0 on main.

@github-actions
Copy link

github-actions bot commented Apr 28, 2022

Size Change: +199 B (0%)

Total Size: 38.4 kB

Filename Size Change
dist/preact.js 4.7 kB +67 B (1%)
dist/preact.min.js 4.76 kB +66 B (1%)
dist/preact.umd.js 4.78 kB +66 B (1%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.63 kB 0 B
compat/dist/compat.umd.js 3.71 kB 0 B
debug/dist/debug.js 3.25 kB 0 B
debug/dist/debug.umd.js 3.33 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
hooks/dist/hooks.js 1.32 kB 0 B
hooks/dist/hooks.umd.js 1.4 kB 0 B
jsx-runtime/dist/jsxRuntime.js 342 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 425 B 0 B
server/dist/server.js 2.6 kB 0 B
server/dist/server.umd.js 2.69 kB 0 B
test-utils/dist/testUtils.js 431 B 0 B
test-utils/dist/testUtils.umd.js 516 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit fba8d60 into main Jun 5, 2022
@JoviDeCroock JoviDeCroock deleted the separate-comp-v2 branch June 5, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants