fix case where we set SCU multiple times #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -5 B (0%) Total Size: 43.9 kB
ℹ️ View Unchanged
|
robertknight
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
The code change looks straightforward. I confirm this fixes the test failures encountered in our app when going from Preact 10.10.0 => 10.10.1: hypothesis/lms#4335.
| @@ -234,6 +234,31 @@ describe('useState', () => { | |||
| expect(scratch.textContent).to.equal('hi'); | |||
| }); | |||
|
|
|||
| it('correctly updates with multiple state updates', () => { | |||
There was a problem hiding this comment.
I'd suggest to add a comment mentioning the original issue, since the sequence of updates needed to trigger the problem is quite specific, rather than this being just a general test for multiple states in one component.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3669
We were setting
hookState._component.__hooks._hasScuFromHooks = true;rather thanhookState._component._hasScuFromHookswhich becomes problematic as we start setting as many SCU's as there are stateful hooks in a component.On the bright side found a golfing opportunity