Preserve event handler return values (#3812)

[andrewiggins]

I'm not aware of any bugs caused by this, but currently we drop the return value of event handlers rather than returning it to the DOM. This corrects that.

Co-authored-by: Jason Miller developit@users.noreply.github.com

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• 03_update10th1k_x16: unsure 🔍 -9% - +8% (-0.47ms - +0.40ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -1% - +1% (-8.62ms - +13.15ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -2% - +2% (-5.37ms - +4.68ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -6% - +7% (-5.54ms - +6.30ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -1% - +1% (-1.33ms - +2.05ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 -1% - +1% (-0.23ms - +0.34ms)
  ^{preact-local vs preact-master}
• todo: unsure 🔍 -2% - +2% (-0.70ms - +0.91ms)
  ^{preact-local vs preact-master}

usedJSHeapSize

• 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.02ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.10ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -6% - +3% (-0.89ms - +0.49ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -1% - +0% (-0.04ms - +0.00ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 -2% - +2% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-master}
• todo: unsure 🔍 -2% - +3% (-0.02ms - +0.03ms)
  ^{preact-local vs preact-master}

Results

03_update10th1k_x16

• Browser: chrome-headless 107.0.5304.121
• Sample size: 100
• Built by: Benchmarks #949

• Commit: eccd0f9

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.95ms - 5.60ms	-	unsure 🔍 -8% - +9% -0.40ms - +0.47ms
preact-local	4.94ms - 5.53ms	unsure 🔍 -9% - +8% -0.47ms - +0.40ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.00ms - 4.02ms	-	unsure 🔍 -0% - +0% -0.02ms - +0.01ms
preact-local	4.01ms - 4.02ms	unsure 🔍 -0% - +0% -0.01ms - +0.02ms	-

07_create10k

• Browser: chrome-headless 107.0.5304.121
• Sample size: 50
• Built by: Benchmarks #949

• Commit: eccd0f9

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	1219.73ms - 1234.29ms	-	unsure 🔍 -1% - +1% -13.15ms - +8.62ms
preact-local	1221.19ms - 1237.37ms	unsure 🔍 -1% - +1% -8.62ms - +13.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	28.63ms - 28.69ms	-	unsure 🔍 -0% - +0% -0.10ms - +0.01ms
preact-local	28.66ms - 28.75ms	unsure 🔍 -0% - +0% -0.01ms - +0.10ms	-

filter_list

• Browser: chrome-headless 107.0.5304.121
• Sample size: 50
• Built by: Benchmarks #949

• Commit: eccd0f9

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	244.35ms - 250.78ms	-	unsure 🔍 -2% - +2% -4.68ms - +5.37ms
preact-local	243.35ms - 251.08ms	unsure 🔍 -2% - +2% -5.37ms - +4.68ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.90ms - 1.93ms	-	unsure 🔍 -1% - +1% -0.02ms - +0.02ms
preact-local	1.90ms - 1.93ms	unsure 🔍 -1% - +1% -0.02ms - +0.02ms	-

hydrate1k

• Browser: chrome-headless 107.0.5304.121
• Sample size: 80
• Built by: Benchmarks #949

• Commit: eccd0f9

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	86.24ms - 94.02ms	-	unsure 🔍 -7% - +6% -6.30ms - +5.54ms
preact-local	86.06ms - 94.97ms	unsure 🔍 -6% - +7% -5.54ms - +6.30ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	14.93ms - 15.89ms	-	unsure 🔍 -3% - +6% -0.49ms - +0.89ms
preact-local	14.72ms - 15.71ms	unsure 🔍 -6% - +3% -0.89ms - +0.49ms	-

many_updates

• Browser: chrome-headless 107.0.5304.121
• Sample size: 50
• Built by: Benchmarks #949

• Commit: eccd0f9

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	236.92ms - 238.81ms	-	unsure 🔍 -1% - +1% -2.05ms - +1.33ms
preact-local	236.81ms - 239.63ms	unsure 🔍 -1% - +1% -1.33ms - +2.05ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	5.59ms - 5.61ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.04ms
preact-local	5.56ms - 5.60ms	unsure 🔍 -1% - +0% -0.04ms - +0.00ms	-

text_update

• Browser: chrome-headless 107.0.5304.121
• Sample size: 50
• Built by: Benchmarks #949

• Commit: eccd0f9

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	45.71ms - 46.14ms	-	unsure 🔍 -1% - +1% -0.34ms - +0.23ms
preact-local	45.79ms - 46.17ms	unsure 🔍 -1% - +1% -0.23ms - +0.34ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.04ms - 1.08ms	-	unsure 🔍 -2% - +2% -0.02ms - +0.02ms
preact-local	1.04ms - 1.08ms	unsure 🔍 -2% - +2% -0.02ms - +0.02ms	-

todo

• Browser: chrome-headless 107.0.5304.121
• Sample size: 50
• Built by: Benchmarks #949

• Commit: eccd0f9

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	41.03ms - 42.33ms	-	unsure 🔍 -2% - +2% -0.91ms - +0.70ms
preact-local	41.31ms - 42.27ms	unsure 🔍 -2% - +2% -0.70ms - +0.91ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.08ms - 1.12ms	-	unsure 🔍 -3% - +2% -0.03ms - +0.02ms
preact-local	1.09ms - 1.12ms	unsure 🔍 -2% - +3% -0.02ms - +0.03ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[coveralls]

Coverage remained the same at 99.435% when pulling eccd0f9 on return-event-handlers into d5c9d72 on v11.

[github-actions]

Size Change: -6 B (0%)

Total Size: 37.6 kB

Filename	Size	Change
dist/preact.js	4.52 kB	+1 B
dist/preact.min.js	4.57 kB	-6 B (0%)
dist/preact.umd.js	4.62 kB	-1 B

ℹ️ View Unchanged

Filename	Size	Change
compat/dist/compat.js	3.54 kB	0 B
compat/dist/compat.umd.js	3.61 kB	0 B
debug/dist/debug.js	3.08 kB	0 B
debug/dist/debug.umd.js	3.17 kB	0 B
devtools/dist/devtools.js	232 B	0 B
devtools/dist/devtools.umd.js	317 B	0 B
hooks/dist/hooks.js	1.46 kB	0 B
hooks/dist/hooks.umd.js	1.54 kB	0 B
jsx-runtime/dist/jsxRuntime.js	296 B	0 B
jsx-runtime/dist/jsxRuntime.umd.js	379 B	0 B
server/dist/server.js	2.6 kB	0 B
server/dist/server.umd.js	2.69 kB	0 B
test-utils/dist/testUtils.js	437 B	0 B
test-utils/dist/testUtils.umd.js	522 B	0 B

_{compressed-size-action}