Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect actDepth calculation in test-utils #4051

Merged
merged 1 commit into from
Jun 25, 2023
Merged

fix: incorrect actDepth calculation in test-utils #4051

merged 1 commit into from
Jun 25, 2023

Conversation

ottomao
Copy link
Contributor

@ottomao ottomao commented Jun 25, 2023

I am submitting this pull request to address a bug in the current implementation of the act method. Specifically, when the act method is called recursively and an inner callback throws an exception, it causes actDepth to be calculated incorrectly, leading to issues with subsequent act method calls.

marvinhagemeister
marvinhagemeister approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! This is a well done PR and love the test for it. Thank you so much for this contribution 💯

@coveralls
Copy link

Coverage Status

coverage: 99.562% (-0.1%) from 99.706% when pulling a12d60e on ottomao:master into 0ef740b on preactjs:master.

@marvinhagemeister marvinhagemeister merged commit a5c810c into preactjs:master Jun 25, 2023
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ottomao @coveralls @marvinhagemeister