Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Suspense fix #4196

Closed
wants to merge 1 commit into from
Closed

Potential Suspense fix #4196

wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 7, 2023 •
edited
Loading

I have not been able to reproduce #4194 however my thinking is that we replace _children erroneously in some cases 😅

@zakstucke mind either providing a reproduction or testing this

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +2% (-2.14ms - +1.50ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -4% - +4% (-1.83ms - +1.48ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +2% (-5.46ms - +15.02ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -4% - +1% (-1.37ms - +0.29ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-7.25ms - +3.11ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +4% (-0.27ms - +1.05ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -4% - +4% (-0.09ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.16ms - +0.48ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -1% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +1% (-0.03ms - +0.03ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main85.63ms - 88.42ms-unsure 🔍
-2% - +2%
-1.50ms - +2.14ms		unsure 🔍
-1% - +3%
-0.87ms - +2.25ms
preact-local85.54ms - 87.87msunsure 🔍
-2% - +2%
-2.14ms - +1.50ms		-unsure 🔍
-1% - +2%
-0.99ms - +1.73ms
preact-hooks85.64ms - 87.04msunsure 🔍
-3% - +1%
-2.25ms - +0.87ms		unsure 🔍
-2% - +1%
-1.73ms - +0.99ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.30ms - 3.31ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local3.30ms - 3.30msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks3.33ms - 3.33msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.97ms - 32.13ms-unsure 🔍
-2% - +4%
-0.52ms - +1.10ms		faster ✔
1% - 6%
0.17ms - 1.94ms
preact-local30.70ms - 31.82msunsure 🔍
-3% - +2%
-1.10ms - +0.52ms		-faster ✔
2% - 7%
0.48ms - 2.21ms
preact-hooks31.95ms - 33.27msslower ❌
1% - 6%
0.17ms - 1.94ms		slower ❌
1% - 7%
0.48ms - 2.21ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main40.66ms - 42.32ms-unsure 🔍
-0% - +5%
-0.11ms - +2.11ms		unsure 🔍
-3% - +2%
-1.18ms - +0.85ms
preact-local39.75ms - 41.24msunsure 🔍
-5% - +0%
-2.11ms - +0.11ms		-faster ✔
1% - 5%
0.21ms - 2.11ms
preact-hooks41.07ms - 42.24msunsure 🔍
-2% - +3%
-0.85ms - +1.18ms		slower ❌
0% - 5%
0.21ms - 2.11ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main35.84ms - 37.74ms-unsure 🔍
-4% - +3%
-1.47ms - +1.17ms		unsure 🔍
-4% - +3%
-1.58ms - +1.05ms
preact-local36.01ms - 37.86msunsure 🔍
-3% - +4%
-1.17ms - +1.47ms		-unsure 🔍
-4% - +3%
-1.41ms - +1.18ms
preact-hooks36.14ms - 37.96msunsure 🔍
-3% - +4%
-1.05ms - +1.58ms		unsure 🔍
-3% - +4%
-1.18ms - +1.41ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main31.05ms - 32.99ms-unsure 🔍
-6% - +3%
-1.85ms - +0.90ms		unsure 🔍
-8% - +0%
-2.77ms - +0.19ms
preact-local31.52ms - 33.47msunsure 🔍
-3% - +6%
-0.90ms - +1.85ms		-unsure 🔍
-7% - +2%
-2.29ms - +0.67ms
preact-hooks32.19ms - 34.43msunsure 🔍
-1% - +9%
-0.19ms - +2.77ms		unsure 🔍
-2% - +7%
-0.67ms - +2.29ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main44.17ms - 47.27ms-unsure 🔍
-6% - +3%
-2.84ms - +1.32ms		unsure 🔍
-7% - +2%
-3.36ms - +0.82ms
preact-local45.09ms - 47.87msunsure 🔍
-3% - +6%
-1.32ms - +2.84ms		-unsure 🔍
-5% - +3%
-2.48ms - +1.47ms
preact-hooks45.59ms - 48.39msunsure 🔍
-2% - +7%
-0.82ms - +3.36ms		unsure 🔍
-3% - +5%
-1.47ms - +2.48ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.82ms - 26.86ms-unsure 🔍
-2% - +4%
-0.45ms - +0.96ms		unsure 🔍
-1% - +4%
-0.30ms - +1.07ms
preact-local25.62ms - 26.55msunsure 🔍
-4% - +2%
-0.96ms - +0.45ms		-unsure 🔍
-2% - +3%
-0.51ms - +0.77ms
preact-hooks25.51ms - 26.39msunsure 🔍
-4% - +1%
-1.07ms - +0.30ms		unsure 🔍
-3% - +2%
-0.77ms - +0.51ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main40.66ms - 42.83ms-unsure 🔍
-4% - +4%
-1.48ms - +1.83ms		unsure 🔍
-2% - +5%
-0.81ms - +2.01ms
preact-local40.33ms - 42.83msunsure 🔍
-4% - +4%
-1.83ms - +1.48ms		-unsure 🔍
-3% - +5%
-1.11ms - +1.96ms
preact-hooks40.25ms - 42.05msunsure 🔍
-5% - +2%
-2.01ms - +0.81ms		unsure 🔍
-5% - +3%
-1.96ms - +1.11ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.26ms - 3.27ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms		faster ✔
0% - 1%
0.01ms - 0.03ms
preact-local3.26ms - 3.26msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-faster ✔
0% - 1%
0.01ms - 0.03ms
preact-hooks3.27ms - 3.29msslower ❌
0% - 1%
0.01ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.03ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main927.73ms - 935.58ms-unsure 🔍
-2% - +1%
-15.02ms - +5.46ms		unsure 🔍
-1% - +0%
-11.37ms - +1.88ms
preact-local926.98ms - 945.89msunsure 🔍
-1% - +2%
-5.46ms - +15.02ms		-unsure 🔍
-1% - +1%
-10.82ms - +10.89ms
preact-hooks931.07ms - 941.73msunsure 🔍
-0% - +1%
-1.88ms - +11.37ms		unsure 🔍
-1% - +1%
-10.89ms - +10.82ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.32ms - 26.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.32ms - 26.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.34ms - 26.34msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.92ms - 32.26ms-unsure 🔍
-1% - +4%
-0.29ms - +1.37ms		unsure 🔍
-2% - +4%
-0.60ms - +1.19ms
preact-local30.55ms - 31.54msunsure 🔍
-4% - +1%
-1.37ms - +0.29ms		-unsure 🔍
-3% - +2%
-1.02ms - +0.53ms
preact-hooks30.70ms - 31.89msunsure 🔍
-4% - +2%
-1.19ms - +0.60ms		unsure 🔍
-2% - +3%
-0.53ms - +1.02ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.33ms - 1.35ms-unsure 🔍
-1% - +1%
-0.02ms - +0.01ms		faster ✔
1% - 3%
0.01ms - 0.04ms
preact-local1.33ms - 1.36msunsure 🔍
-1% - +1%
-0.01ms - +0.02ms		-faster ✔
1% - 3%
0.01ms - 0.04ms
preact-hooks1.36ms - 1.38msslower ❌
1% - 3%
0.01ms - 0.04ms		slower ❌
1% - 3%
0.01ms - 0.04ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main172.78ms - 181.20ms-unsure 🔍
-2% - +4%
-3.11ms - +7.25ms		unsure 🔍
-3% - +3%
-4.75ms - +6.00ms
preact-local171.91ms - 177.93msunsure 🔍
-4% - +2%
-7.25ms - +3.11ms		-unsure 🔍
-3% - +2%
-5.95ms - +3.05ms
preact-hooks173.03ms - 179.71msunsure 🔍
-3% - +3%
-6.00ms - +4.75ms		unsure 🔍
-2% - +3%
-3.05ms - +5.95ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.12ms - 6.12ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-local6.12ms - 6.13msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-unsure 🔍
-0% - -0%
-0.03ms - -0.01ms
preact-hooks6.14ms - 6.15msunsure 🔍
+0% - +0%
+0.02ms - +0.03ms		unsure 🔍
+0% - +0%
+0.01ms - +0.03ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.09ms - 25.82ms-unsure 🔍
-4% - +1%
-1.05ms - +0.27ms		unsure 🔍
-4% - +1%
-1.11ms - +0.22ms
preact-local25.30ms - 26.40msunsure 🔍
-1% - +4%
-0.27ms - +1.05ms		-unsure 🔍
-3% - +3%
-0.84ms - +0.73ms
preact-hooks25.34ms - 26.46msunsure 🔍
-1% - +4%
-0.22ms - +1.11ms		unsure 🔍
-3% - +3%
-0.73ms - +0.84ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.49ms - 4.53ms-unsure 🔍
-1% - +1%
-0.03ms - +0.03ms		unsure 🔍
-1% - +0%
-0.04ms - +0.02ms
preact-local4.49ms - 4.53msunsure 🔍
-1% - +1%
-0.03ms - +0.03ms		-unsure 🔍
-1% - +0%
-0.04ms - +0.01ms
preact-hooks4.50ms - 4.54msunsure 🔍
-0% - +1%
-0.02ms - +0.04ms		unsure 🔍
-0% - +1%
-0.01ms - +0.04ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.27ms - 2.40ms-unsure 🔍
-4% - +4%
-0.09ms - +0.09ms		faster ✔
10% - 18%
0.27ms - 0.50ms
preact-local2.28ms - 2.40msunsure 🔍
-4% - +4%
-0.09ms - +0.09ms		-faster ✔
10% - 18%
0.27ms - 0.49ms
preact-hooks2.62ms - 2.81msslower ❌
11% - 22%
0.27ms - 0.50ms		slower ❌
11% - 21%
0.27ms - 0.49ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.74ms - 0.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 3%
0.01ms - 0.03ms
preact-local0.74ms - 0.74msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 4%
0.01ms - 0.03ms
preact-hooks0.76ms - 0.77msslower ❌
2% - 4%
0.01ms - 0.03ms		slower ❌
2% - 4%
0.01ms - 0.03ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.82ms - 28.29ms-unsure 🔍
-2% - +1%
-0.48ms - +0.16ms		faster ✔
3% - 5%
0.95ms - 1.44ms
preact-local27.99ms - 28.44msunsure 🔍
-1% - +2%
-0.16ms - +0.48ms		-faster ✔
3% - 4%
0.80ms - 1.27ms
preact-hooks29.17ms - 29.33msslower ❌
3% - 5%
0.95ms - 1.44ms		slower ❌
3% - 5%
0.80ms - 1.27ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.78ms - 0.78ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
3% - 3%
0.02ms - 0.03ms
preact-local0.78ms - 0.78msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
3% - 3%
0.02ms - 0.02ms
preact-hooks0.80ms - 0.80msslower ❌
3% - 3%
0.02ms - 0.03ms		slower ❌
3% - 3%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Nov 7, 2023 •
edited
Loading

Coverage Status

coverage: 99.429%. remained the same
when pulling 0197560 on suspense-issue
into 046af87 on main.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Size Change: +16 B (0%)

Total Size: 57.4 kB

Filename Size Change
dist/preact.js 4.42 kB +3 B (0%)
dist/preact.min.js 4.46 kB +2 B (0%)
dist/preact.min.module.js 4.46 kB +3 B (0%)
dist/preact.min.umd.js 4.48 kB +2 B (0%)
dist/preact.module.js 4.45 kB +3 B (0%)
dist/preact.umd.js 4.49 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.97 kB 0 B
compat/dist/compat.module.js 3.9 kB 0 B
compat/dist/compat.umd.js 4.04 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.62 kB 0 B
jsx-runtime/dist/jsxRuntime.js 365 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 331 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 445 B 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@zakstucke
Copy link
Contributor

@JoviDeCroock just locally packaged and installed this branch, still failing with same errors :(

@JoviDeCroock JoviDeCroock deleted the suspense-issue branch November 7, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @zakstucke