-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve types of hook source #4229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve typings of options used in hooks
Size Change: -26 B (0%) Total Size: 59.6 kB
ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Dec 13, 2023
marvinhagemeister
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'm all for stronger typing. Going with unknown
is the right move imo 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the typing in hooks source file and add it to the jsconfig for linting on each PR.
One big change, that others may have opinions about, is that here I used
unknown
for types where we explicitly don't know what it is because it is user provided (e.g. the return type of the callback given touseMemo
). Meaning, usages ofany
in hooks are places where we could improve the types, but I couldn't be bothered cuz it wasn't straightforward. Something to consider improving for later lol.I wanted to to do this cuz I was recently looking at a compat bug in hooks and was working on a fix but refactoring things in hooks was slightly more difficult given I couldn't trust the red squiggles to be meaningful or not. After this PR they are hopefully more helpful (or at least mean you should double check this before adding an
any
override lol).