Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 10.14 release line #4263

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Backport 10.14 release line #4263

merged 14 commits into from
Jan 23, 2024

Conversation

JoviDeCroock
Copy link
Member

This omits the PR's relating to controlled inputs

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 03_update10th1k_x16: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 07_create10k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • filter_list: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • hydrate1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • many_updates: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • text_update: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • todo: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 03_update10th1k_x16: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 07_create10k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • filter_list: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • hydrate1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • many_updates: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • text_update: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • todo: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master79.61ms - 80.83ms-unsure 🔍
-0% - +2%
+0.00ms - +1.54ms
preact-local78.98ms - 79.92msfaster ✔
0% - 2%
0.00ms - 1.54ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.45ms - 3.45ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.45ms - 3.45msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master28.44ms - 29.17ms-unsure 🔍
-3% - +0%
-0.95ms - +0.07ms
preact-local28.89ms - 29.60msunsure 🔍
-0% - +3%
-0.07ms - +0.95ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master28.76ms - 29.61ms-unsure 🔍
-4% - +0%
-1.15ms - +0.12ms
preact-local29.22ms - 30.17msunsure 🔍
-0% - +4%
-0.12ms - +1.15ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master30.53ms - 31.43ms-unsure 🔍
-2% - +2%
-0.67ms - +0.61ms
preact-local30.55ms - 31.47msunsure 🔍
-2% - +2%
-0.61ms - +0.67ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master79.64ms - 80.86ms-unsure 🔍
-0% - +2%
+0.00ms - +1.54ms
preact-local79.00ms - 79.95msfaster ✔
0% - 2%
0.00ms - 1.54ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.42ms - 32.83ms-unsure 🔍
-4% - +2%
-1.44ms - +0.66ms
preact-local31.74ms - 33.29msunsure 🔍
-2% - +5%
-0.66ms - +1.44ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.51ms - 3.51ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.51ms - 3.51msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master908.58ms - 922.61ms-unsure 🔍
-1% - +1%
-10.03ms - +11.88ms
preact-local906.26ms - 923.09msunsure 🔍
-1% - +1%
-11.88ms - +10.03ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master122.43ms - 123.95ms-unsure 🔍
-1% - +1%
-1.79ms - +0.81ms
preact-local122.62ms - 124.74msunsure 🔍
-1% - +1%
-0.81ms - +1.79ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.52ms - 1.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.52ms - 1.53msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master66.63ms - 69.01ms-unsure 🔍
-3% - +2%
-1.70ms - +1.51ms
preact-local66.84ms - 68.99msunsure 🔍
-2% - +3%
-1.51ms - +1.70ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.01ms - 6.01ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local6.01ms - 6.02msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master111.80ms - 112.93ms-unsure 🔍
-1% - +0%
-1.13ms - +0.53ms
preact-local112.06ms - 113.27msunsure 🔍
-0% - +1%
-0.53ms - +1.13ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.89ms - 4.89ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local4.89ms - 4.89msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.37ms - 29.87ms-unsure 🔍
-0% - +2%
-0.13ms - +0.45ms
preact-local29.32ms - 29.60msunsure 🔍
-1% - +0%
-0.45ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.78ms - 0.78ms-unsure 🔍
-0% - +1%
-0.00ms - +0.00ms
preact-local0.78ms - 0.78msunsure 🔍
-1% - +0%
-0.00ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-local
preact-master21.04ms - 21.43ms-unsure 🔍
-0% - +2%
-0.07ms - +0.38ms
preact-local20.96ms - 21.20msunsure 🔍
-2% - +0%
-0.38ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.79ms - 0.79ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local0.79ms - 0.79msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Jan 22, 2024 •
edited
Loading

Coverage Status

coverage: 99.321% (+0.1%) from 99.172%
when pulling c61f145 on v11-10-14
into 4601cf3 on v11.

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Jan 22, 2024 •
edited
Loading

Gotta check what's wrong with the compressed size action later but I don't think this should block us from backporting all commits 😅

for future reference, something always writes "[object Object]\n" to the mangle.json

@JoviDeCroock JoviDeCroock merged commit f0144e6 into v11 Jan 23, 2024
11 of 12 checks passed
@JoviDeCroock JoviDeCroock deleted the v11-10-14 branch January 23, 2024 09:39
ritschwumm
ritschwumm reviewed Jan 24, 2024
View reviewed changes
compat/test/browser/render.test.js
@@ -495,6 +495,21 @@ describe('compat render', () => {
);
});

it('shouldnot transform imageSrcSet', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnot or should not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritschwumm ritschwumm ritschwumm left review comments

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoviDeCroock @coveralls @ritschwumm @marvinhagemeister