Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support passing context into pure component #4269

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

JoviDeCroock
Copy link
Member

fixes #4268

@JoviDeCroock JoviDeCroock force-pushed the context-pure-component branch from e58efa5 to 230c852 Compare January 29, 2024 11:10
@coveralls
Copy link

coveralls commented Jan 29, 2024

Coverage Status

coverage: 99.473%. remained the same
when pulling 230c852 on context-pure-component
into 79be156 on main.

Copy link

github-actions bot commented Jan 29, 2024

Size Change: +23 B (0%)

Total Size: 60 kB

Filename Size Change
compat/dist/compat.js 3.99 kB +9 B (0%)
compat/dist/compat.module.js 3.91 kB +7 B (0%)
compat/dist/compat.umd.js 4.05 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.js 4.54 kB 0 B
dist/preact.min.js 4.58 kB 0 B
dist/preact.min.module.js 4.58 kB 0 B
dist/preact.min.umd.js 4.61 kB 0 B
dist/preact.module.js 4.57 kB 0 B
dist/preact.umd.js 4.62 kB 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 49433b3 into main Jan 29, 2024
3 checks passed
@JoviDeCroock JoviDeCroock deleted the context-pure-component branch January 29, 2024 13:17
@Silviu-Marian
Copy link

@JoviDeCroock thanks for the speedy fix on this. Do you have any idea when it will be available through npm? Is there a release calendar of anything of sorts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no context in preact/compat/PureComponent and it breaks other libraries like react-recurly
4 participants