Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Syntax in compat/client for IE11 support #4372

Merged
merged 3 commits into from
May 6, 2024
Merged

fix: Syntax in compat/client for IE11 support #4372

merged 3 commits into from
May 6, 2024

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented May 5, 2024 •
edited
Loading

Closes #4371

Not that this case is problematic, but might be worth considering passing all package exports through Microbundle in the future to catch this sort of thing.

rschristian
rschristian commented May 5, 2024
View reviewed changes
compat/client.js Show resolved Hide resolved
compat/client.mjs Show resolved Hide resolved
compat/client.js Show resolved Hide resolved
compat/client.mjs Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 99.609%. remained the same
when pulling 41ce33b on rschristian-patch-1
into d18ac9f on main.

@rschristian rschristian merged commit 414c870 into main May 6, 2024
2 checks passed
@rschristian rschristian deleted the rschristian-patch-1 branch May 6, 2024 05:52
@JoviDeCroock JoviDeCroock mentioned this pull request May 15, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
Open
@vAHiD55555 vAHiD55555 mentioned this pull request Jun 20, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 22, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Aug 10, 2024
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
This was referenced Aug 14, 2024
Open
Open
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@arkid15r arkid15r mentioned this pull request Sep 11, 2024
Closed
@ntavassoli-dot ntavassoli-dot mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@organich organich mentioned this pull request Sep 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Open
@abaum65 abaum65 mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createRoot uses an unsupported syntax for IE11
3 participants
@rschristian @coveralls @marvinhagemeister