only check is connected for dom nodes #4409

JoviDeCroock · 2024-06-15T11:06:49Z

isConnected is not present on text nodes, this prevents us from crashing due to calling getDomSibling for a text node. This does highlight that Google Translate leads to a bug, in the example given in #4318 (comment) we get the following as output

This is translated to Dutch, as you can see the h1 and the first hello reconcile correctly, however everything after the interpolated {label} does not.

When I replace {props.label} with a normal string or with <span>{props.label}</span> it does work correctly.

This does however not solve the other issue mentioned on this PR, which does not have a way to reproduce. I reckon that one could be related to the dom-sibling of oldVNode also not being connected due to removing a lot of fragment-like wrapped children and oldDom being captured to the first of said list.

github-actions · 2024-06-15T11:07:02Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +0% (-11.43ms - +2.83ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -3% - +2% (-0.57ms - +0.33ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -5% - +3% (-3.31ms - +1.99ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -2% - +2% (-0.33ms - +0.31ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -3% - +1% (-2.43ms - +1.15ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -5% - +3% (-0.10ms - +0.06ms)
^{preact-local vs preact-main}
todo: faster ✔ 4% - 7% (1.11ms - 1.92ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -4% - +2% (-1.43ms - +0.65ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -2% - +2% (-0.30ms - +0.30ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.04ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	866.04ms - 872.89ms	-	unsure 🔍 -1% - +0% -11.43ms - +2.83ms
preact-main	867.51ms - 880.02ms	unsure 🔍 -0% - +1% -2.83ms - +11.43ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.15ms - 25.15ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	25.15ms - 25.15ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.65ms - 17.07ms	-	unsure 🔍 -3% - +2% -0.57ms - +0.33ms
preact-main	16.58ms - 17.38ms	unsure 🔍 -2% - +3% -0.33ms - +0.57ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.69ms - 1.69ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.69ms - 1.69ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	68.84ms - 72.11ms	-	unsure 🔍 -5% - +3% -3.31ms - +1.99ms
preact-main	69.04ms - 73.22ms	unsure 🔍 -3% - +5% -1.99ms - +3.31ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	13.13ms - 13.59ms	-	unsure 🔍 -2% - +2% -0.30ms - +0.30ms
preact-main	13.17ms - 13.54ms	unsure 🔍 -2% - +2% -0.30ms - +0.30ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	18.18ms - 18.71ms	-	unsure 🔍 -2% - +2% -0.33ms - +0.31ms
preact-main	18.28ms - 18.63ms	unsure 🔍 -2% - +2% -0.31ms - +0.33ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.61ms - 4.61ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	4.61ms - 4.61ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	81.45ms - 84.07ms	-	unsure 🔍 -3% - +1% -2.43ms - +1.15ms
preact-main	82.18ms - 84.62ms	unsure 🔍 -1% - +3% -1.15ms - +2.43ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.54ms - 3.57ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.04ms
preact-main	3.52ms - 3.56ms	unsure 🔍 -1% - +0% -0.04ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.89ms - 30.45ms	-	unsure 🔍 -1% - +1% -0.42ms - +0.42ms
preact-main	29.86ms - 30.49ms	unsure 🔍 -1% - +1% -0.42ms - +0.42ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.42ms - 37.48ms	-	unsure 🔍 -3% - +4% -1.26ms - +1.52ms
preact-main	35.40ms - 37.26ms	unsure 🔍 -4% - +3% -1.52ms - +1.26ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.11ms - 27.59ms	-	unsure 🔍 -1% - +2% -0.26ms - +0.43ms
preact-main	27.01ms - 27.51ms	unsure 🔍 -2% - +1% -0.43ms - +0.26ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.72ms - 35.66ms	-	unsure 🔍 -3% - +4% -1.06ms - +1.45ms
preact-main	33.70ms - 35.29ms	unsure 🔍 -4% - +3% -1.45ms - +1.06ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.60ms - 24.33ms	-	unsure 🔍 -1% - +8% -0.30ms - +1.81ms
preact-main	22.10ms - 23.32ms	unsure 🔍 -8% - +1% -1.81ms - +0.30ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.30ms - 26.55ms	-	unsure 🔍 -2% - +5% -0.51ms - +1.30ms
preact-main	24.87ms - 26.18ms	unsure 🔍 -5% - +2% -1.30ms - +0.51ms	-

text-update

Browser: chrome-headless
Sample size: 100
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.95ms - 2.06ms	-	unsure 🔍 -5% - +3% -0.10ms - +0.06ms
preact-main	1.96ms - 2.08ms	unsure 🔍 -3% - +5% -0.06ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.98ms - 0.98ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	0.98ms - 0.98ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

Browser: chrome-headless
Sample size: 120
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.59ms - 25.75ms	-	faster ✔ 4% - 7% 1.11ms - 1.92ms
preact-main	26.79ms - 27.58ms	slower ❌ 4% - 7% 1.11ms - 1.92ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.25ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1557
Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.18ms - 36.07ms	-	unsure 🔍 -4% - +2% -1.43ms - +0.65ms
preact-main	35.08ms - 36.96ms	unsure 🔍 -2% - +4% -0.65ms - +1.43ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.55ms - 3.55ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-main	3.55ms - 3.55ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-06-15T11:07:56Z

Size Change: +39 B (+0.06%)

Total Size: 61.8 kB

Filename	Size	Change
`dist/preact.js`	4.68 kB	+7 B (+0.15%)
`dist/preact.min.js`	4.71 kB	+6 B (+0.13%)
`dist/preact.min.module.js`	4.71 kB	+6 B (+0.13%)
`dist/preact.min.umd.js`	4.74 kB	+6 B (+0.13%)
`dist/preact.module.js`	4.7 kB	+9 B (+0.19%)
`dist/preact.umd.js`	4.75 kB	+5 B (+0.11%)

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	4.1 kB
`compat/dist/compat.module.js`	4.03 kB
`compat/dist/compat.umd.js`	4.17 kB
`debug/dist/debug.js`	3.7 kB
`debug/dist/debug.module.js`	3.71 kB
`debug/dist/debug.umd.js`	3.78 kB
`devtools/dist/devtools.js`	259 B
`devtools/dist/devtools.module.js`	273 B
`devtools/dist/devtools.umd.js`	345 B
`hooks/dist/hooks.js`	1.53 kB
`hooks/dist/hooks.module.js`	1.56 kB
`hooks/dist/hooks.umd.js`	1.6 kB
`jsx-runtime/dist/jsxRuntime.js`	981 B
`jsx-runtime/dist/jsxRuntime.module.js`	956 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.06 kB
`test-utils/dist/testUtils.js`	451 B
`test-utils/dist/testUtils.module.js`	456 B
`test-utils/dist/testUtils.umd.js`	536 B

_{compressed-size-action}

coveralls · 2024-06-15T11:09:10Z

coverage: 99.611%. remained the same
when pulling 4d8357a on only-check-for-dom-nodes
into 4c20c23 on main.

coveralls · 2024-06-15T11:09:18Z

coverage: 99.611%. remained the same
when pulling 4d8357a on only-check-for-dom-nodes
into 4c20c23 on main.

coveralls · 2024-06-15T11:11:08Z

coverage: 99.611%. remained the same
when pulling 0a17073 on only-check-for-dom-nodes
into 4c20c23 on main.

coveralls · 2024-06-15T11:11:14Z

coverage: 99.611%. remained the same
when pulling 0a17073 on only-check-for-dom-nodes
into 4c20c23 on main.

coveralls · 2024-06-15T11:11:16Z

coverage: 99.611%. remained the same
when pulling 0a17073 on only-check-for-dom-nodes
into 4c20c23 on main.

coveralls · 2024-06-15T11:11:27Z

coverage: 99.611%. remained the same
when pulling 0a17073 on only-check-for-dom-nodes
into 4c20c23 on main.

coveralls · 2024-06-25T13:49:32Z

coverage: 99.611%. remained the same
when pulling 0c05391 on only-check-for-dom-nodes
into 92e86e9 on main.

coveralls · 2024-06-25T13:49:36Z

coverage: 99.611%. remained the same
when pulling 0c05391 on only-check-for-dom-nodes
into 92e86e9 on main.

coveralls · 2024-06-25T15:33:08Z

coverage: 99.482% (-0.1%) from 99.611%
when pulling bd29648 on only-check-for-dom-nodes
into eb37677 on main.

coveralls · 2024-06-25T15:33:22Z

coverage: 99.482% (-0.1%) from 99.611%
when pulling bd29648 on only-check-for-dom-nodes
into eb37677 on main.

coveralls · 2024-06-25T15:33:48Z

coverage: 99.611%. remained the same
when pulling bd29648 on only-check-for-dom-nodes
into eb37677 on main.

coveralls · 2024-06-25T15:33:49Z

coverage: 99.611%. remained the same
when pulling bd29648 on only-check-for-dom-nodes
into eb37677 on main.

coveralls · 2024-06-28T12:53:53Z

coverage: 99.611%. remained the same
when pulling 75f1b71 on only-check-for-dom-nodes
into 76f5d66 on main.

coveralls · 2024-06-28T12:54:04Z

coverage: 99.611%. remained the same
when pulling 75f1b71 on only-check-for-dom-nodes
into 76f5d66 on main.

…to DOM issues See the following for the changes introduced which might have caused this: - preactjs/preact#4409 - preactjs/preact#4421 - preactjs/preact#4403

JoviDeCroock force-pushed the only-check-for-dom-nodes branch from 87376bc to 0a17073 Compare June 15, 2024 11:08

JoviDeCroock mentioned this pull request Jun 15, 2024

fix: check whether oldDom is present in the DOM #4318

Merged

JoviDeCroock requested review from developit, andrewiggins and marvinhagemeister June 15, 2024 11:16

JoviDeCroock force-pushed the only-check-for-dom-nodes branch from 0a17073 to 0c05391 Compare June 25, 2024 13:47

only check is connected for dom nodes

e69f7e4

JoviDeCroock force-pushed the only-check-for-dom-nodes branch from 0c05391 to 4c114f9 Compare June 25, 2024 15:30

optimize by not accessing the dom

bd29648

JoviDeCroock force-pushed the only-check-for-dom-nodes branch from 4c114f9 to bd29648 Compare June 25, 2024 15:31

marvinhagemeister approved these changes Jun 28, 2024

View reviewed changes

Merge branch 'main' into only-check-for-dom-nodes

75f1b71

JoviDeCroock merged commit 16aeb9f into main Jun 28, 2024
13 checks passed

JoviDeCroock deleted the only-check-for-dom-nodes branch June 28, 2024 12:56

JoviDeCroock mentioned this pull request Jun 30, 2024

10.22.1 #4428

Merged

JoviDeCroock mentioned this pull request Jul 18, 2024

fix(child-diffing): Should shift keyed fragmented lists #4448

Merged

2 tasks

X-oss-byte mentioned this pull request Jul 22, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.22.1 X-oss-byte/next-auth#107

Open

lorenzoAtBEIS mentioned this pull request Aug 10, 2024

[Snyk] Upgrade preact from 10.22.0 to 10.22.1 UKGovernmentBEIS/inspect_ai#228

Merged

ZeroXClem mentioned this pull request Aug 12, 2024

[Snyk] Upgrade preact from 10.20.1 to 10.22.1 ZeroXClem/metamesa#4

Closed

This was referenced Aug 14, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.0 X-oss-byte/next-auth#109

Open

[Snyk] Upgrade preact from 10.11.3 to 10.23.1 X-oss-byte/next-auth#110

Open

ramzimalhas mentioned this pull request Aug 22, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.1 ramzimalhas/chatgpt-advanced#2

Open

This was referenced Sep 3, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.2 X-oss-byte/next-auth#113

Open

[Snyk] Upgrade: cookie, preact, preact-render-to-string X-oss-byte/next-auth#115

Open

arkid15r mentioned this pull request Sep 11, 2024

[Snyk] Upgrade: , dayjs, marked-emoji, preact, qs, react-router-dom, sass VictoriaMetrics/VictoriaMetrics#6982

Closed

ntavassoli-dot mentioned this pull request Sep 13, 2024

[Snyk] Upgrade preact from 10.13.2 to 10.23.2 ntavassoli-dot/InstagramUnfollowers#1

Open

organich mentioned this pull request Sep 24, 2024

[Snyk] Upgrade preact from 10.19.3 to 10.23.2 organich/vscode-js-debug#3

Open

X-oss-byte mentioned this pull request Oct 5, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.0 X-oss-byte/next-auth#123

Open

X-oss-byte mentioned this pull request Oct 18, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.1 X-oss-byte/next-auth#125

Open

X-oss-byte mentioned this pull request Oct 25, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.2 X-oss-byte/next-auth#127

Open

Xcaciv mentioned this pull request Oct 27, 2024

[Snyk] Upgrade preact from 10.22.0 to 10.24.2 Xcaciv/appsec-test-2024#3

Open

dwhiteGUK mentioned this pull request Oct 28, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.2 dwhiteGUK/dlw.dev#39

Open

abaum65 mentioned this pull request Oct 31, 2024

[Snyk] Upgrade preact from 10.22.0 to 10.24.2 abaum65/saintcon-appsec-challenge-2024#4

Open

only check is connected for dom nodes #4409

only check is connected for dom nodes #4409

Conversation

JoviDeCroock commented Jun 15, 2024 • edited Loading

github-actions bot commented Jun 15, 2024 • edited Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

github-actions bot commented Jun 15, 2024 • edited Loading

coveralls commented Jun 15, 2024

coveralls commented Jun 15, 2024

coveralls commented Jun 15, 2024

coveralls commented Jun 15, 2024

coveralls commented Jun 15, 2024

coveralls commented Jun 15, 2024

coveralls commented Jun 25, 2024

coveralls commented Jun 25, 2024

coveralls commented Jun 25, 2024

coveralls commented Jun 25, 2024

coveralls commented Jun 25, 2024

coveralls commented Jun 25, 2024

coveralls commented Jun 28, 2024

coveralls commented Jun 28, 2024

JoviDeCroock commented Jun 15, 2024 •

edited

Loading

github-actions bot commented Jun 15, 2024 •

edited

Loading

github-actions bot commented Jun 15, 2024 •

edited

Loading