Single text node hot path

[JoviDeCroock]

Supersedes #3939

Similar to 3939 we are seeing some operations take longer as rather than mutating the text-node we'll be swapping positions instead. The impact seems higher in skew based diff though so not sure whether the performance impact will be as high as in 3939.

The replace_1k difference is similar to #3939 (comment)

This could also be problematic with signals as text-updates won't automatically update afaik

Looks like this should not break signals actually

From #2618 we can derive that there are actually a lot of cases where the single child type is a text-node.

[rschristian]

Re:Andre's comment about the "regression" in replace1k, have you by chance tried giving it more warmup runs? Say bumping up to 25 like a few of the other benches?

That very well might have been in one of your force pushes, just thought I'd ask.

[rschristian]

Looking at the results, the warmup might close the gap a little on average, but not totally: https://github.com/preactjs/preact/actions/runs/11304050028/job/31441949188

Can probably revert/drop that, sorry. Was good to confirm I suppose though.

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -0% - +1% (-3.97ms - +6.07ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -3% - +1% (-0.53ms - +0.11ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +0% (-0.69ms - +0.33ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -2% - +2% (-0.32ms - +0.35ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -3% - +2% (-2.43ms - +1.49ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -0% - +9% (-0.01ms - +0.20ms)
  ^{preact-local vs preact-main}
• todo: faster ✔ 3% - 7% (1.06ms - 2.41ms)
  ^{preact-local vs preact-main}
• update10th1k: faster ✔ 4% - 9% (1.57ms - 3.25ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +2% (-0.00ms - +0.03ms)
  ^{preact-local vs preact-main}
• hydrate1k: faster ✔ 0% - 4% (0.03ms - 0.59ms)
  ^{preact-local vs preact-main}
• many-updates: slower ❌ 34% - 35% (1.58ms - 1.61ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
  ^{preact-local vs preact-main}
• update10th1k: slower ❌ 52% - 53% (1.84ms - 1.87ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	936.90ms - 944.83ms	-	unsure 🔍 -0% - +1% -3.97ms - +6.07ms
preact-main	936.74ms - 942.89ms	unsure 🔍 -1% - +0% -6.07ms - +3.97ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.28ms - 25.28ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	25.28ms - 25.28ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.46ms - 16.60ms	-	unsure 🔍 -3% - +1% -0.53ms - +0.11ms
preact-main	16.43ms - 17.05ms	unsure 🔍 -1% - +3% -0.11ms - +0.53ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.67ms - 1.69ms	-	unsure 🔍 -0% - +2% -0.00ms - +0.03ms
preact-main	1.66ms - 1.67ms	unsure 🔍 -2% - +0% -0.03ms - +0.00ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 80
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	68.27ms - 68.80ms	-	unsure 🔍 -1% - +0% -0.69ms - +0.33ms
preact-main	68.28ms - 69.15ms	unsure 🔍 -0% - +1% -0.33ms - +0.69ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	12.65ms - 13.07ms	-	faster ✔ 0% - 4% 0.03ms - 0.59ms
preact-main	12.98ms - 13.36ms	slower ❌ 0% - 5% 0.03ms - 0.59ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.56ms - 16.60ms	-	unsure 🔍 -2% - +2% -0.32ms - +0.35ms
preact-main	16.23ms - 16.90ms	unsure 🔍 -2% - +2% -0.35ms - +0.32ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	6.16ms - 6.18ms	-	slower ❌ 34% - 35% 1.58ms - 1.61ms
preact-main	4.57ms - 4.59ms	faster ✔ 26% - 26% 1.58ms - 1.61ms	-

replace1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	76.63ms - 79.37ms	-	unsure 🔍 -3% - +2% -2.43ms - +1.49ms
preact-main	77.06ms - 79.87ms	unsure 🔍 -2% - +3% -1.49ms - +2.43ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.56ms - 3.59ms	-	unsure 🔍 -1% - +1% -0.02ms - +0.02ms
preact-main	3.56ms - 3.59ms	unsure 🔍 -1% - +1% -0.02ms - +0.02ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.04ms - 31.93ms	-	unsure 🔍 -3% - +1% -0.86ms - +0.47ms
preact-main	31.19ms - 32.16ms	unsure 🔍 -2% - +3% -0.47ms - +0.86ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	36.54ms - 38.43ms	-	unsure 🔍 -2% - +4% -0.91ms - +1.47ms
preact-main	36.49ms - 37.93ms	unsure 🔍 -4% - +2% -1.47ms - +0.91ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.65ms - 27.18ms	-	unsure 🔍 -2% - +2% -0.53ms - +0.49ms
preact-main	26.51ms - 27.37ms	unsure 🔍 -2% - +2% -0.49ms - +0.53ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	28.93ms - 30.79ms	-	unsure 🔍 -4% - +5% -1.04ms - +1.55ms
preact-main	28.70ms - 30.51ms	unsure 🔍 -5% - +3% -1.55ms - +1.04ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	21.23ms - 21.89ms	-	unsure 🔍 -0% - +4% -0.06ms - +0.81ms
preact-main	20.91ms - 21.47ms	unsure 🔍 -4% - +0% -0.81ms - +0.06ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	23.45ms - 24.16ms	-	unsure 🔍 -2% - +2% -0.58ms - +0.54ms
preact-main	23.40ms - 24.26ms	unsure 🔍 -2% - +2% -0.54ms - +0.58ms	-

text-update

• Browser: chrome-headless
• Sample size: 220
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.13ms - 2.29ms	-	unsure 🔍 -0% - +9% -0.01ms - +0.20ms
preact-main	2.05ms - 2.19ms	unsure 🔍 -9% - +0% -0.20ms - +0.01ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.10ms - 1.11ms	-	unsure 🔍 -1% - +0% -0.01ms - +0.00ms
preact-main	1.11ms - 1.11ms	unsure 🔍 -0% - +1% -0.00ms - +0.01ms	-

todo

• Browser: chrome-headless
• Sample size: 110
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.45ms - 32.77ms	-	faster ✔ 3% - 7% 1.06ms - 2.41ms
preact-main	33.69ms - 34.01ms	slower ❌ 3% - 8% 1.06ms - 2.41ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.23ms - 1.23ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.01ms
preact-main	1.22ms - 1.23ms	unsure 🔍 -1% - +0% -0.01ms - +0.00ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 130
• Built by: CI #3992

• Commit: df6c646

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	32.88ms - 34.18ms	-	faster ✔ 4% - 9% 1.57ms - 3.25ms
preact-main	35.40ms - 36.47ms	slower ❌ 5% - 10% 1.57ms - 3.25ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	5.38ms - 5.40ms	-	slower ❌ 52% - 53% 1.84ms - 1.87ms
preact-main	3.53ms - 3.54ms	faster ✔ 34% - 35% 1.84ms - 1.87ms	-

_{tachometer-reporter-action v2 for CI}

[marvinhagemeister]

Very impressed with the findings. Really good work!

[github-actions]

Size Change: +230 B (+0.37%)

Total Size: 62.4 kB

Filename	Size	Change
dist/preact.js	4.72 kB	+39 B (+0.83%)
dist/preact.min.js	4.75 kB	+37 B (+0.79%)
dist/preact.min.module.js	4.75 kB	+39 B (+0.83%)
dist/preact.min.umd.js	4.77 kB	+37 B (+0.78%)
dist/preact.module.js	4.74 kB	+41 B (+0.87%)
dist/preact.umd.js	4.79 kB	+37 B (+0.78%)

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	4.13 kB
compat/dist/compat.module.js	4.05 kB
compat/dist/compat.umd.js	4.19 kB
debug/dist/debug.js	3.82 kB
debug/dist/debug.module.js	3.83 kB
debug/dist/debug.umd.js	3.9 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.module.js	274 B
devtools/dist/devtools.umd.js	346 B
hooks/dist/hooks.js	1.53 kB
hooks/dist/hooks.module.js	1.56 kB
hooks/dist/hooks.umd.js	1.6 kB
jsx-runtime/dist/jsxRuntime.js	976 B
jsx-runtime/dist/jsxRuntime.module.js	949 B
jsx-runtime/dist/jsxRuntime.umd.js	1.05 kB
test-utils/dist/testUtils.js	451 B
test-utils/dist/testUtils.module.js	456 B
test-utils/dist/testUtils.umd.js	536 B

_{compressed-size-action}

[JoviDeCroock]

Closing due to the memory regression