-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove saucelabs #4530
Merged
Merged
ci: Remove saucelabs #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
force-pushed
the
ci/saucelabs
branch
from
October 12, 2024 08:19
9e11cdb
to
2a2df49
Compare
Size Change: 0 B Total Size: 62.1 kB ℹ️ View Unchanged
|
rschristian
force-pushed
the
ci/saucelabs
branch
from
October 12, 2024 08:23
2a2df49
to
61f02fe
Compare
JoviDeCroock
approved these changes
Oct 12, 2024
rschristian
commented
Oct 12, 2024
@@ -217,6 +217,7 @@ | |||
"benchmark": "^2.1.4", | |||
"chai": "^4.1.2", | |||
"check-export-map": "^1.3.1", | |||
"core-js": "^3.38.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We rely on core-js
in our polyfill tests:
Line 2 in c9846f1
import 'core-js/es/map'; |
Undeclared dep, hence the additon here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if anyone is opposed to this, but it's been failing for the last 10 months straight, with 4 working commits, then another 5 months of failures which is where the actions history runs out.
Looks like
karma-sauce-launcher
has been abandoned w/ no changes in the last 2 years, and is 4 majors behind the currentsaucelabs
version. Per NPM, the karma launcher down to half the downloads per week compared to last year, so I'm guessing everyone else is bailing off it too.