Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix PR reporter #4531

Merged
merged 1 commit into from
Oct 13, 2024
Merged

ci: Fix PR reporter #4531

merged 1 commit into from
Oct 13, 2024

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Oct 13, 2024

This should correct the PR reporter

There's no elegant way to watch jobs within a workflow, so we'll have to settle for mirroring CI's filter here to ensure we're only running the PR reporter when the benchmarks will be ran (**/src/**/*.js)

filters: |
jsChanged: '**/src/**.js'
jsChanged: '**/src/**/*.js'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we found in ad1fdf5

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling 21956d6 on ci/fix-pr-reporter
into 162d71f on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants