types: Move per-element type interfaces into core and more strictly type IntrinsicElements #4546
+1,183
−1,868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
force-pushed
the
refactor/intrinsic-elements-and-attributes
branch
2 times, most recently
from
94fdf20
to
0e8bee0
Compare
rschristian
changed the title
rschristian
force-pushed
the
refactor/intrinsic-elements-and-attributes
branch
from
868e5a4
to
a450a2f
Compare
1 task
|
@rschristian Nice, I have updated the table to include the new types |
|
Awesome, thanks! Jovi & I were both looking at that, will take another look soon-ish to see which types we're missing (that we do support). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4544 and #4202
Someone kindly contributed type interfaces for most elements to compat, so this PR takes those, moves them into core, and alters
IntrinsicElementsto use those more specific interfaces rather than the massive & genericHTMLAttributesthat we used to have. That interface still exists, however, it's been renamed toAllHTMLAttributes, matching React. The newHTMLAttributesis strictly limited to global attributes/props, only the things that are valid & make sense everywhere.As such, with this PR
<div src="/foo.jpg">will now correctly result in a type error. I'm slightly concerned about breakages because of this but I think it's an unavoidable bandaid we'll have to rip off at some point.This is a fairly big change and I expect we will have some issues raised. There's 240 or so attributes now spread across a couple dozen interfaces. I've done my best to ensure this is correct but there's a lot of surface area here.