Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split mount and patch #4567

Draft
wants to merge 4 commits into
base: v11-2
Choose a base branch
from
Draft

Split mount and patch #4567

wants to merge 4 commits into from
+921 −310

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 23, 2024 •
edited
Loading

This is a heavy Work in progress but it will serve as the first step to reviving the work for backing-nodes. Don't worry about the byte-size here yet, this is currently convoluted and will enable a lot of work like tree-shakeable class components.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-7.01ms - +0.66ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.35ms - +0.10ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +0% (-1.40ms - +0.03ms)
    preact-local vs preact-main
  • many-updates: slower ❌ 1% - 7% (0.19ms - 1.16ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 1% - 4% (0.38ms - 2.39ms)
    preact-local vs preact-main
  • text-update: slower ❌ 24% - 44% (0.56ms - 0.91ms)
    preact-local vs preact-main
  • todo: faster ✔ 5% - 6% (1.56ms - 2.09ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +4% (-0.57ms - +1.44ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.07ms - +0.07ms)
    preact-local vs preact-main
  • filter-list: slower ❌ 6% - 8% (0.10ms - 0.12ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 2% - 8% (0.27ms - 1.13ms)
    preact-local vs preact-main
  • many-updates: slower ❌ 2% - 2% (0.08ms - 0.11ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: slower ❌ 7% - 8% (0.07ms - 0.09ms)
    preact-local vs preact-main
  • todo: slower ❌ 8% - 9% (0.10ms - 0.11ms)
    preact-local vs preact-main
  • update10th1k: slower ❌ 3% - 4% (0.09ms - 0.13ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local940.80ms - 946.97ms-unsure 🔍
-1% - +0%
-7.01ms - +0.66ms
preact-main944.78ms - 949.34msunsure 🔍
-0% - +1%
-0.66ms - +7.01ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local24.91ms - 24.91ms-unsure 🔍
+0% - +0%
+0.07ms - +0.07ms
preact-main24.83ms - 24.83msunsure 🔍
-0% - -0%
-0.07ms - -0.07ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.56ms - 16.62ms-unsure 🔍
-2% - +1%
-0.35ms - +0.10ms
preact-main16.49ms - 16.93msunsure 🔍
-1% - +2%
-0.10ms - +0.35ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.73ms - 1.76ms-slower ❌
6% - 8%
0.10ms - 0.12ms
preact-main1.63ms - 1.64msfaster ✔
6% - 7%
0.10ms - 0.12ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.19ms - 73.30ms-unsure 🔍
-2% - +0%
-1.40ms - +0.03ms
preact-main72.98ms - 73.87msunsure 🔍
-0% - +2%
-0.03ms - +1.40ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local12.81ms - 13.33ms-faster ✔
2% - 8%
0.27ms - 1.13ms
preact-main13.43ms - 14.12msslower ❌
2% - 9%
0.27ms - 1.13ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local17.39ms - 18.16ms-slower ❌
1% - 7%
0.19ms - 1.16ms
preact-main16.81ms - 17.40msfaster ✔
1% - 6%
0.19ms - 1.16ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.59ms - 4.60ms-slower ❌
2% - 2%
0.08ms - 0.11ms
preact-main4.49ms - 4.51msfaster ✔
2% - 2%
0.08ms - 0.11ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4089

  • Commit: 2181325

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.76ms - 68.79ms-slower ❌
1% - 4%
0.38ms - 2.39ms
preact-main66.02ms - 67.76msfaster ✔
1% - 3%
0.38ms - 2.39ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.57ms - 3.58ms-unsure 🔍
-0% - +0%
-0.02ms - +0.02ms
preact-main3.56ms - 3.59msunsure 🔍
-0% - +0%
-0.02ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local31.99ms - 32.97ms-slower ❌
2% - 6%
0.67ms - 1.96ms
preact-main30.75ms - 31.58msfaster ✔
2% - 6%
0.67ms - 1.96ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local28.07ms - 28.67ms-faster ✔
17% - 20%
5.88ms - 7.22ms
preact-main34.33ms - 35.51msslower ❌
21% - 26%
5.88ms - 7.22ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.79ms - 30.96ms-slower ❌
1% - 7%
0.45ms - 1.94ms
preact-main28.71ms - 29.65msfaster ✔
2% - 6%
0.45ms - 1.94ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local22.07ms - 22.44ms-faster ✔
4% - 7%
0.86ms - 1.69ms
preact-main23.16ms - 23.91msslower ❌
4% - 8%
0.86ms - 1.69ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local20.77ms - 21.38ms-unsure 🔍
-3% - +1%
-0.69ms - +0.12ms
preact-main21.10ms - 21.63msunsure 🔍
-1% - +3%
-0.12ms - +0.69ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local19.88ms - 20.21ms-unsure 🔍
-4% - -0%
-0.76ms - +0.00ms
preact-main20.08ms - 20.77msunsure 🔍
-0% - +4%
-0.00ms - +0.76ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.78ms - 3.03ms-slower ❌
24% - 44%
0.56ms - 0.91ms
preact-main2.04ms - 2.29msfaster ✔
20% - 31%
0.56ms - 0.91ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.18ms - 1.18ms-slower ❌
7% - 8%
0.07ms - 0.09ms
preact-main1.09ms - 1.11msfaster ✔
6% - 7%
0.07ms - 0.09ms		-
todo
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #4089

  • Commit: 2181325

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.21ms - 32.57ms-faster ✔
5% - 6%
1.56ms - 2.09ms
preact-main34.02ms - 34.40msslower ❌
5% - 6%
1.56ms - 2.09ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.32ms - 1.33ms-slower ❌
8% - 9%
0.10ms - 0.11ms
preact-main1.21ms - 1.22msfaster ✔
8% - 9%
0.10ms - 0.11ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.72ms - 34.35ms-unsure 🔍
-2% - +4%
-0.57ms - +1.44ms
preact-main32.52ms - 33.69msunsure 🔍
-4% - +2%
-1.44ms - +0.57ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.57ms - 3.59ms-slower ❌
3% - 4%
0.09ms - 0.13ms
preact-main3.45ms - 3.49msfaster ✔
2% - 3%
0.09ms - 0.13ms		-

tachometer-reporter-action v2 for CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

Size Change: +6.15 kB (+10.13%) ⚠️

Total Size: 66.9 kB

Filename Size Change
dist/preact.js 5.63 kB +1.02 kB (+22.11%) 🚨
dist/preact.min.js 5.66 kB +1.01 kB (+21.76%) 🚨
dist/preact.min.module.js 5.66 kB +1.02 kB (+22.02%) 🚨
dist/preact.min.umd.js 5.68 kB +1.01 kB (+21.61%) 🚨
dist/preact.module.js 5.65 kB +1.01 kB (+21.88%) 🚨
dist/preact.umd.js 5.77 kB +1.07 kB (+22.89%) 🚨
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.79 kB
compat/dist/compat.module.js 3.71 kB
compat/dist/compat.umd.js 3.84 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 973 B
jsx-runtime/dist/jsxRuntime.module.js 947 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the split-mount-patch branch 3 times, most recently from 701de9e to e6542a9 Compare November 23, 2024 09:42
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 24, 2024
Closed
@JoviDeCroock JoviDeCroock force-pushed the split-mount-patch branch 3 times, most recently from 72f59c9 to 35f0cc7 Compare November 24, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoviDeCroock