Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): mark datetime on <del> as optional #4570

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(types): mark datetime on <del> as optional #4570

merged 1 commit into from
Nov 25, 2024

Conversation

marvinhagemeister
Copy link
Member

In #4554 the datetime attribute of <del> was accidentally marked as required. This PR fixes that.

@squidfunk squidfunk mentioned this pull request Nov 25, 2024
Closed
rschristian
rschristian approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap, sorry!

@marvinhagemeister
Copy link
Member Author

No worries, could've happened to anyone

@marvinhagemeister marvinhagemeister merged commit bd14437 into main Nov 25, 2024
6 checks passed
@marvinhagemeister marvinhagemeister deleted the del-datetime-optional branch November 25, 2024 10:54
@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling c7ae2d2 on del-datetime-optional
into 269cdd8 on main.

@rschristian rschristian mentioned this pull request Nov 27, 2024
Merged
@JoviDeCroock JoviDeCroock mentioned this pull request Dec 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

@JoviDeCroock JoviDeCroock Awaiting requested review from JoviDeCroock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @coveralls @rschristian