Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Restrict aria roles by element type #4607

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

refactor: Restrict aria roles by element type #4607

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9d1c845
refactor: Restrict aria roles by element type
rschristian Dec 13, 2024
d707458
test: Add simple test for button roles
rschristian Dec 13, 2024
4fb26f6
refactor: Make roles signalish
rschristian Dec 13, 2024
308615b
test: Add tests for `never` roles
rschristian Dec 15, 2024
6a6f672
refactor: Remove half-implemented select roles
rschristian Dec 16, 2024
29a30e0
fix: Ensure attributes w/ `never` roles can be constructed
rschristian Dec 16, 2024
be33fad
refactor: Restrict more complex aria roles
rschristian Dec 17, 2024
69efe76
refactor: Remove unused input type interface, fix select multiple type
rschristian Dec 17, 2024
152c4e0
fix: Ensure partials extend EventTarget
rschristian Dec 17, 2024
600cd35
revert: Bring back input type attribute
rschristian Dec 17, 2024
f66acff
test: Fix test typo
rschristian Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading